feat: account details pages w/o 7702 #33964

hmalik88 · 2025-06-27T16:13:45Z

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

What is the reason for the change? Account details pages were needed for the various account types.
What is the improvement/solution? Use the reusable components created for the new screens to build the account details pages.

NOTE: This PR omits 7702 integration, will be followed up in a separate PR.

Manual testing steps

Create a .manifest-overrides.json file in the root and add the following:

{
  "_flags": {
    "remoteFeatureFlags": {
      "addSolanaAccount": true,
      "enableMultichainAccounts": {
        "enabled": true,
        "featureVersion": "1",
        "minimumVersion": "12.0.0"
      }
    }
  }
}

Navigate to an account's details page through either the hamburger menu or the global account selector
Observe the results.

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… account type\'s account details page

… styling

…oute based on feature flag

…etails

…state 1 flag is not active

…props

…nent in evm account details

cursor

Bug: Missing Address Parameter in Account Navigation

The handleAccountClick function incorrectly navigates to account details by pushing ACCOUNT_DETAILS_ROUTE without the required address parameter. The ACCOUNT_DETAILS_ROUTE now expects an :address parameter, causing navigation to fail or result in a 404.

ui/pages/multichain-accounts/wallet-details/wallet-details.component.tsx#L79-L83

metamask-extension/ui/pages/multichain-accounts/wallet-details/wallet-details.component.tsx

Lines 79 to 83 in 9153933

    
           const handleAccountClick = (account: { id: string; address: string }) => { 
        
             dispatch(setAccountDetailsAddress(account.address)); 
        
             history.push(ACCOUNT_DETAILS_ROUTE); 
        
           };

Fix in Cursor

Bug: Test Fails Due to Route Parameter Change

The test for navigating to the QR code route has an incorrect expectation. It expects navigation to ACCOUNT_DETAILS_QR_CODE_ROUTE, but the actual implementation now navigates to ${ACCOUNT_DETAILS_QR_CODE_ROUTE}/${address} (including the address parameter). The test expectation needs to be updated to reflect this change.

ui/pages/multichain-accounts/base-account-details/base-account-details.test.tsx#L259-L260

metamask-extension/ui/pages/multichain-accounts/base-account-details/base-account-details.test.tsx

Lines 259 to 260 in 9153933


	expect(mockPush).toHaveBeenCalledWith(ACCOUNT_DETAILS_QR_CODE_ROUTE);

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

cursor

Bug: Missing Address Parameter in Navigation

The handleAccountClick function in wallet-details.component.tsx navigates to ACCOUNT_DETAILS_ROUTE without including the required :address parameter. The ACCOUNT_DETAILS_ROUTE is defined to expect this parameter, leading to a route mismatch and preventing successful navigation to the account details page. The navigation should be history.push(${ACCOUNT_DETAILS_ROUTE}/${account.address});.

ui/pages/multichain-accounts/wallet-details/wallet-details.component.tsx#L79-L83

metamask-extension/ui/pages/multichain-accounts/wallet-details/wallet-details.component.tsx

Lines 79 to 83 in 066fb00

    
           const handleAccountClick = (account: { id: string; address: string }) => { 
        
             dispatch(setAccountDetailsAddress(account.address)); 
        
             history.push(ACCOUNT_DETAILS_ROUTE); 
        
           };

Fix in Cursor

Bug: Undefined URL Parameter Causes Runtime Errors

The address obtained from useParams() can be undefined if the URL parameter is missing or malformed. This potentially undefined value is then used directly, often with a type assertion as string, and passed to functions like getInternalAccountByAddress and components such as QrCodeView without null checking, which can lead to runtime errors.

ui/pages/multichain-accounts/address-qr-code/address-qr-code.tsx#L38-L91

metamask-extension/ui/pages/multichain-accounts/address-qr-code/address-qr-code.tsx

Lines 38 to 91 in 066fb00

    
           const history = useHistory(); 
        
           const { address } = useParams(); 
        
           const trackEvent = useContext(MetaMetricsContext); 
        
           const account = useSelector((state) => 
        
             getInternalAccountByAddress(state, address), 
        
           ); 
        
           const multichainNetwork = useMultichainSelector( 
        
             getMultichainNetwork, 
        
             account, 
        
           ); 
        
           const addressLink = getMultichainAccountUrl( 
        
             account.address, 
        
             multichainNetwork, 
        
           ); 
        
           const chainId = parseCaipChainId(multichainNetwork.chainId).reference; 
        
           const metricsLocation = 'Account Details QR Code Page'; 
        
           const handleNavigation = useCallback(() => { 
        
             trackEvent({ 
        
               event: MetaMetricsEventName.BlockExplorerLinkClicked, 
        
               category: MetaMetricsEventCategory.Accounts, 
        
               properties: { 
        
                 location: metricsLocation, 
        
                 chain_id: chainId, 
        
               }, 
        
             }); 
        
             openBlockExplorer(addressLink, metricsLocation, trackEvent); 
        
           }, [chainId, trackEvent, addressLink]); 
        
           return ( 
        
             <Page className="address-qr-code-page"> 
        
               <Header 
        
                 backgroundColor={BackgroundColor.backgroundDefault} 
        
                 startAccessory={ 
        
                   <ButtonIcon 
        
                     ariaLabel="Back" 
        
                     iconName={IconName.ArrowLeft} 
        
                     size={ButtonIconSize.Sm} 
        
                     onClick={() => history.push(`${ACCOUNT_DETAILS_ROUTE}/${address}`)} 
        
                   /> 
        
                 } 
        
               > 
        
                 {t('address')} 
        
               </Header> 
        
               <Content paddingTop={0}> 
        
                 <QrCodeView 
        
                   Qr={{ data: address as string }} 
        
                   location="Account Details Page" 
        
                 /> 
        
               </Content>

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

metamaskbot · 2025-07-01T13:52:39Z

Builds ready [066fb00]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 80 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1085	1612	80	1246	1337
			load	1030	909	1477	78	1068	1149
			domContentLoaded	1022	906	1471	78	1057	1140
			domInteractive	18	13	47	6	16	36
			firstPaint	741	141	1146	389	1039	1139
			backgroundConnect	8	4	31	4	8	14
			firstReactRender	21	17	45	4	22	30
			getState	16	6	111	12	22	32
			initialActions	0	0	1	0	0	1
			loadScripts	815	704	1260	77	853	932
			setupStore	8	5	31	4	8	17
	Webpack	Home	uiStartup	2339	1734	3047	237	2451	2823
			load	1752	1300	2267	205	1867	2131
			domContentLoaded	1745	1296	2249	202	1862	2125
			domInteractive	20	13	145	19	16	61
			firstPaint	166	65	694	84	185	313
			backgroundConnect	26	10	98	12	30	46
			firstReactRender	258	97	412	103	355	403
			getState	17	5	60	10	21	37
			initialActions	3	1	7	1	3	5
			loadScripts	1741	1294	2237	200	1860	2115
			setupStore	24	8	180	24	27	48
Firefox	Browserify	Home	uiStartup	1433	1224	2298	156	1504	1765
			load	1256	1091	2166	130	1322	1419
			domContentLoaded	1256	1091	2166	130	1322	1419
			domInteractive	125	36	1142	115	124	305
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	193	24	22	34
			firstReactRender	25	22	34	3	26	31
			getState	13	5	175	20	9	34
			initialActions	0	0	1	0	0	1
			loadScripts	1237	1077	2153	128	1307	1388
			setupStore	11	4	201	22	8	29
	Webpack	Home	uiStartup	1675	1418	2775	230	1765	2207
			load	1436	1220	1943	170	1549	1858
			domContentLoaded	1436	1219	1942	170	1548	1857
			domInteractive	120	36	539	102	105	485
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	143	14	28	44
			firstReactRender	43	34	55	4	46	49
			getState	19	5	375	46	10	57
			initialActions	0	0	1	0	1	1
			loadScripts	1414	1203	1920	170	1529	1836
			setupStore	12	5	229	25	9	32

Benchmark value 17 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 2340 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1752 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1745 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 259 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 1742 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2823 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2131 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2126 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2115 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1434 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1257 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1257 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 125 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1237 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1765 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 305 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 29 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1675 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1437 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1436 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 121 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1414 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2207 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1858 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1857 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 485 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1836 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 645ms | Sum of p95 exceeds: 2231ms
Sum of all benchmark exceeds: 2876ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 33 Bytes (0%)
ui: 22.06 KiB (0.3%)
common: 15 Bytes (0%)

cursor · 2025-07-01T14:43:42Z

🚨 BugBot couldn't run

BugBot is experiencing high demand right now. Try again in a few minutes by commenting "bugbot run" (requestId: serverGenReqId_da1331d5-ca95-4e72-bf91-f7937b83f4ea).

metamaskbot · 2025-07-01T15:07:27Z

Builds ready [38fc83a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1179 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1179	1057	1400	64	1216	1326
			load	1003	908	1207	59	1033	1096
			domContentLoaded	997	904	1196	58	1028	1084
			domInteractive	17	13	50	5	16	29
			firstPaint	624	128	1203	399	1007	1083
			backgroundConnect	7	4	30	3	8	11
			firstReactRender	21	17	38	3	22	27
			getState	16	6	33	8	22	31
			initialActions	0	0	1	0	0	1
			loadScripts	794	701	995	57	824	881
			setupStore	8	5	24	3	8	16
	Webpack	Home	uiStartup	2212	1765	2765	223	2290	2701
			load	1673	1270	2073	182	1771	2031
			domContentLoaded	1667	1266	2054	180	1765	2015
			domInteractive	19	12	104	17	14	62
			firstPaint	172	64	1771	172	181	305
			backgroundConnect	24	10	278	27	24	44
			firstReactRender	249	91	416	117	374	400
			getState	12	4	47	8	13	32
			initialActions	2	1	8	1	3	4
			loadScripts	1664	1264	2044	178	1763	2004
			setupStore	25	7	327	49	18	52
Firefox	Browserify	Home	uiStartup	1428	1227	2017	141	1488	1688
			load	1245	1053	1575	93	1314	1402
			domContentLoaded	1245	1053	1575	93	1314	1401
			domInteractive	117	35	450	58	127	190
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	114	16	22	49
			firstReactRender	26	22	51	5	27	35
			getState	15	4	240	35	9	34
			initialActions	0	0	1	0	0	1
			loadScripts	1225	1036	1487	90	1299	1379
			setupStore	14	4	290	35	8	63
	Webpack	Home	uiStartup	1622	1394	2202	189	1740	1991
			load	1400	1204	1855	157	1518	1718
			domContentLoaded	1400	1203	1855	157	1518	1718
			domInteractive	105	31	391	71	93	319
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	15	76	9	25	41
			firstReactRender	42	31	61	4	45	49
			getState	13	6	86	13	10	34
			initialActions	0	0	1	0	1	1
			loadScripts	1378	1182	1837	157	1498	1698
			setupStore	11	4	88	12	9	37

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 2212 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 249 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2702 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2031 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2016 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2005 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1428 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1246 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1245 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 14 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1688 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 63 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1622 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1401 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1400 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1379 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1991 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1718 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 319 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 34 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1698 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 160ms | Sum of p95 exceeds: 819ms
Sum of all benchmark exceeds: 979ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 33 Bytes (0%)
ui: 22.41 KiB (0.31%)
common: 15 Bytes (0%)

cursor · 2025-07-01T16:36:51Z

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_9365452e-d57f-4a3a-9c99-e5d2ba809cbd).

metamaskbot · 2025-07-01T17:01:01Z

Builds ready [ce6d4c8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1183 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1183	1048	1553	72	1218	1295
			load	1005	901	1364	63	1041	1117
			domContentLoaded	999	896	1350	61	1035	1108
			domInteractive	18	13	67	8	17	39
			firstPaint	719	145	1356	393	1024	1089
			backgroundConnect	7	4	15	2	8	13
			firstReactRender	24	18	58	8	25	42
			getState	16	6	102	12	22	30
			initialActions	0	0	1	0	0	1
			loadScripts	794	700	1136	60	828	893
			setupStore	8	5	22	3	9	16
	Webpack	Home	uiStartup	2361	1716	2891	218	2501	2811
			load	1772	1274	2256	204	1899	2108
			domContentLoaded	1765	1268	2250	202	1894	2095
			domInteractive	20	13	136	18	15	59
			firstPaint	181	69	1547	155	207	321
			backgroundConnect	30	13	459	44	30	47
			firstReactRender	231	95	421	102	342	400
			getState	26	5	329	53	22	58
			initialActions	2	1	6	1	3	5
			loadScripts	1761	1266	2247	201	1892	2084
			setupStore	27	8	321	43	26	45
Firefox	Browserify	Home	uiStartup	1406	1238	1928	134	1458	1700
			load	1229	1060	1571	93	1278	1399
			domContentLoaded	1228	1060	1571	93	1278	1399
			domInteractive	127	36	415	76	130	333
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	107	13	22	47
			firstReactRender	26	22	53	6	26	50
			getState	13	5	213	23	9	51
			initialActions	0	0	2	0	0	1
			loadScripts	1211	1008	1547	94	1260	1376
			setupStore	14	4	324	39	7	50
	Webpack	Home	uiStartup	1677	1400	2368	209	1769	2168
			load	1446	1199	1958	165	1541	1802
			domContentLoaded	1445	1199	1958	165	1541	1802
			domInteractive	109	61	486	77	96	324
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	14	136	13	26	40
			firstReactRender	43	31	68	5	46	49
			getState	12	5	87	10	10	32
			initialActions	1	0	2	1	1	1
			loadScripts	1424	1180	1933	164	1522	1770
			setupStore	15	5	282	33	9	31

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 2361 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1773 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1765 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1762 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2811 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2108 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2096 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 60 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 400 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2084 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1406 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1700 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 333 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 51 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 50 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1678 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1446 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1446 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 110 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1424 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2168 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 324 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1770 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 662ms | Sum of p95 exceeds: 1729ms
Sum of all benchmark exceeds: 2391ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 33 Bytes (0%)
ui: 22.41 KiB (0.31%)
common: 15 Bytes (0%)

metamaskbot · 2025-07-01T18:15:15Z

Builds ready [cfabe05]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1200 ± 78 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1200	1055	1417	78	1253	1348
			load	1027	909	1216	74	1085	1159
			domContentLoaded	1020	904	1212	73	1074	1148
			domInteractive	17	14	43	7	17	39
			firstPaint	597	71	1154	410	1025	1107
			backgroundConnect	8	4	27	3	9	13
			firstReactRender	24	17	40	6	26	37
			getState	16	6	37	8	22	31
			initialActions	0	0	5	1	0	1
			loadScripts	814	708	988	70	869	938
			setupStore	9	6	24	4	9	19
	Webpack	Home	uiStartup	2204	1636	2778	217	2296	2635
			load	1659	1225	2256	192	1778	1985
			domContentLoaded	1653	1221	2252	191	1772	1970
			domInteractive	18	12	76	15	14	66
			firstPaint	176	63	423	74	197	351
			backgroundConnect	24	12	279	27	23	44
			firstReactRender	261	90	441	123	387	410
			getState	13	4	143	15	15	26
			initialActions	5	1	303	30	3	6
			loadScripts	1650	1220	2241	189	1767	1960
			setupStore	19	7	287	28	19	36
Firefox	Browserify	Home	uiStartup	1462	1248	1911	136	1506	1781
			load	1274	1114	1512	90	1328	1449
			domContentLoaded	1274	1114	1511	90	1328	1449
			domInteractive	119	37	430	65	124	309
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	12	205	25	24	88
			firstReactRender	26	21	49	4	27	36
			getState	12	5	96	13	10	51
			initialActions	0	0	1	0	0	1
			loadScripts	1252	1098	1496	90	1313	1421
			setupStore	16	4	220	38	8	71
	Webpack	Home	uiStartup	1661	1417	2614	221	1738	2183
			load	1424	1224	1870	155	1523	1708
			domContentLoaded	1423	1224	1870	155	1523	1708
			domInteractive	107	60	384	65	99	298
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	257	25	26	47
			firstReactRender	43	32	66	5	46	50
			getState	20	5	351	47	11	86
			initialActions	1	0	2	1	1	1
			loadScripts	1398	1205	1843	149	1493	1659
			setupStore	17	5	239	38	8	103

Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2205 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 262 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2635 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 66 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 351 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 410 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1462 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1275 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1274 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1253 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1781 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 309 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 88 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 51 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 71 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1662 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1424 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1424 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1398 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2183 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1708 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1708 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 298 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 86 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1659 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 103 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 408ms | Sum of p95 exceeds: 1217ms
Sum of all benchmark exceeds: 1625ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 33 Bytes (0%)
ui: 22.39 KiB (0.31%)
common: 15 Bytes (0%)

hmalik88 added 30 commits June 25, 2025 16:16

feat: create account details component that switches into the correct…

e620f03

… account type\'s account details page

test: add mock account data

92e1dd4

feat: add account details pages for various account types

2379206

feat: conditionally render account details based on state 1 flag

94abd24

test: update tests

f399be7

chore: rename account details page to multichain account details

8a34473

chore: remove extra account types from utils

f7191e5

chore: update exports

4a250be

refactor: remove unnecessary code from evm account details

164d8ce

feat: move selectors into props, add useEffect for navigation, update…

f1b74a3

… styling

Merge branch 'main' into hm/mul-283

79d4a34

feat: add private key account details page

fde920f

test: fix account details tests

6862014

fix: update mock accounts and fix utils

cad293f

chore: remove unused props

5e1edbb

feat: add multichain account details route

9501960

feat: add logic to conditionally push to multichain account details r…

525fb8d

…oute based on feature flag

feat: add logic to prevent app header from appearing for account details

0cd26c0

feat: add accountDetailsAddress selector back to multichain account d…

1d1dbd6

…etails

feat: add logic to prevent navigation to new account details page if …

f5b0637

…state 1 flag is not active

feat: add logic to remove app header for address qr code page

6ebf8b4

feat: add navigation protection for address qr code page

43d4710

feat: add address qr code route

15be842

fix: update condition to be navigate protect when flag is NOT enabled

14f3f49

Merge branch 'main' into hm/mul-283

2ea64d5

feat: update smart contract account toggle components to use address …

f0b252c

…props

fix: update prop type

0951f7e

feat: add address prop to smart contract account toggle section compo…

922e4c2

…nent in evm account details

chore: update types

646da78

fix: update storybook file with correct props

c926716

hmalik88 added 3 commits July 1, 2025 09:06

fix: apply code review

addb079

Merge branch 'main' into hm/283without7702

a4ff93f

fix: fix routing

9153933

cursor bot reviewed Jul 1, 2025

View reviewed changes

feat: add btc account details page

066fb00

cursor bot reviewed Jul 1, 2025

View reviewed changes

hmalik88 added 2 commits July 1, 2025 10:38

fix: apply fixes for text styling and navigation

d853bf1

test: add btc account tests

38fc83a

hmalik88 added 3 commits July 1, 2025 12:29

fix: add routing to account details tests

c5f638f

fix: add routing to address qr code stories

10f4217

fix: apply lint fix

ce6d4c8

hmalik88 added 4 commits July 1, 2025 13:18

fix: apply lint fix

5268bc1

fix: add routing to address qr code tests

f5d6676

Merge branch 'main' into hm/283without7702

da13839

fix: fix base account details test

cfabe05

david0xd approved these changes Jul 1, 2025

View reviewed changes

vinnyhoward approved these changes Jul 1, 2025

View reviewed changes

hmalik88 added this pull request to the merge queue Jul 1, 2025

Merged via the queue into main with commit 4353cf2 Jul 1, 2025
271 of 275 checks passed

hmalik88 deleted the hm/283without7702 branch July 1, 2025 19:28

github-actions bot locked and limited conversation to collaborators Jul 1, 2025

metamaskbot added the release-12.23.0 Issue or pull request that will be included in release 12.23.0 label Jul 1, 2025

gantunesr assigned hmalik88 Jul 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: account details pages w/o 7702 #33964

feat: account details pages w/o 7702 #33964

hmalik88 commented Jun 27, 2025 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot left a comment

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

cursor bot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

cursor bot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!


	const handleAccountClick = (account: { id: string; address: string }) => {
	dispatch(setAccountDetailsAddress(account.address));
	history.push(ACCOUNT_DETAILS_ROUTE);
	};

	const history = useHistory();
	const { address } = useParams();
	const trackEvent = useContext(MetaMetricsContext);
	const account = useSelector((state) =>
	getInternalAccountByAddress(state, address),
	);

	const multichainNetwork = useMultichainSelector(
	getMultichainNetwork,
	account,
	);

	const addressLink = getMultichainAccountUrl(
	account.address,
	multichainNetwork,
	);

	const chainId = parseCaipChainId(multichainNetwork.chainId).reference;

	const metricsLocation = 'Account Details QR Code Page';

	const handleNavigation = useCallback(() => {
	trackEvent({
	event: MetaMetricsEventName.BlockExplorerLinkClicked,
	category: MetaMetricsEventCategory.Accounts,
	properties: {
	location: metricsLocation,
	chain_id: chainId,
	},
	});
	openBlockExplorer(addressLink, metricsLocation, trackEvent);
	}, [chainId, trackEvent, addressLink]);

	return (
	<Page className="address-qr-code-page">
	<Header
	backgroundColor={BackgroundColor.backgroundDefault}
	startAccessory={
	<ButtonIcon
	ariaLabel="Back"
	iconName={IconName.ArrowLeft}
	size={ButtonIconSize.Sm}
	onClick={() => history.push(`${ACCOUNT_DETAILS_ROUTE}/${address}`)}
	/>
	}
	>
	{t('address')}
	</Header>
	<Content paddingTop={0}>
	<QrCodeView
	Qr={{ data: address as string }}
	location="Account Details Page"
	/>
	</Content>

feat: account details pages w/o 7702 #33964

feat: account details pages w/o 7702 #33964

Conversation

hmalik88 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing Address Parameter in Account Navigation

Bug: Test Fails Due to Route Parameter Change

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing Address Parameter in Navigation

Bug: Undefined URL Parameter Causes Runtime Errors

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

cursor bot commented Jul 1, 2025

🚨 BugBot couldn't run

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

cursor bot commented Jul 1, 2025

🚨 BugBot couldn't run

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

metamaskbot commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

hmalik88 commented Jun 27, 2025 •

edited

Loading