fix: Network Manager style polish #33968

gambinish · 2025-06-27T18:03:52Z

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-27T18:04:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…dditional network list item

metamaskbot · 2025-06-27T18:19:28Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (3 files, +20 -14)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 network-manager/
      - 📁 components/
        
        📁 additional-networks-info/
        
        📄 additional-networks-info.test.tsx +9 -13
        
        📄 additional-networks-info.tsx +2 -1
        
        📄 index.scss +9 -0

metamaskbot · 2025-06-27T18:41:20Z

Builds ready [5ae154d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1272 ± 81 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1272	1088	1470	81	1315	1408
			load	1087	934	1271	75	1138	1217
			domContentLoaded	1080	928	1258	75	1131	1209
			domInteractive	19	14	63	7	19	35
			firstPaint	717	84	1271	436	1089	1212
			backgroundConnect	8	4	46	5	8	12
			firstReactRender	24	16	54	7	24	43
			getState	15	6	46	8	22	29
			initialActions	0	0	1	0	0	1
			loadScripts	861	723	1018	68	908	986
			setupStore	9	6	27	3	9	18
	Webpack	Home	uiStartup	2214	1661	2798	250	2333	2708
			load	1689	1245	2097	207	1810	2050
			domContentLoaded	1679	1241	2086	205	1803	2044
			domInteractive	18	12	94	16	14	59
			firstPaint	163	66	391	65	182	311
			backgroundConnect	27	10	290	38	25	37
			firstReactRender	248	91	422	117	379	403
			getState	13	5	47	6	15	27
			initialActions	3	1	6	1	3	4
			loadScripts	1676	1235	2075	204	1801	2029
			setupStore	17	7	41	6	20	30
Firefox	Browserify	Home	uiStartup	1366	1202	1683	103	1395	1629
			load	1203	1044	1521	80	1249	1336
			domContentLoaded	1202	1044	1521	80	1249	1336
			domInteractive	119	35	477	68	123	303
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	110	14	21	34
			firstReactRender	24	21	35	2	25	29
			getState	11	4	143	17	9	34
			initialActions	0	0	24	2	0	1
			loadScripts	1185	1029	1497	79	1231	1312
			setupStore	7	4	21	3	7	16
	Webpack	Home	uiStartup	1610	1380	2058	167	1715	2010
			load	1392	1172	1693	142	1508	1656
			domContentLoaded	1391	1172	1693	142	1508	1656
			domInteractive	99	34	318	59	91	282
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	40	5	23	35
			firstReactRender	43	32	76	5	45	49
			getState	12	6	40	7	12	32
			initialActions	0	0	2	1	1	1
			loadScripts	1373	1155	1673	141	1489	1633
			setupStore	8	5	40	5	8	21

Benchmark value 1273 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1087 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1080 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 861 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1408 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1217 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1209 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1212 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 986 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 18 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2214 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 249 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2709 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2051 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2045 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2030 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 119 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 303 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 34 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1392 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1392 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1373 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2010 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 282 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1633 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 196ms | Sum of p95 exceeds: 911ms
Sum of all benchmark exceeds: 1107ms

…ign-polish

metamaskbot · 2025-06-27T21:21:02Z

Builds ready [58d62cc]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1183 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1183	1070	1406	62	1225	1291
			load	1012	909	1153	56	1053	1105
			domContentLoaded	1005	904	1139	55	1046	1092
			domInteractive	17	14	52	6	16	31
			firstPaint	690	129	1146	400	1031	1093
			backgroundConnect	8	4	27	4	8	16
			firstReactRender	23	16	52	6	24	39
			getState	16	6	51	9	21	34
			initialActions	0	0	1	0	0	1
			loadScripts	799	704	928	54	836	886
			setupStore	9	5	26	4	8	20
	Webpack	Home	uiStartup	2232	1776	2823	215	2339	2685
			load	1697	1334	2194	188	1799	2029
			domContentLoaded	1691	1330	2183	187	1789	2013
			domInteractive	18	12	99	15	14	53
			firstPaint	170	69	754	97	187	316
			backgroundConnect	22	11	54	8	26	38
			firstReactRender	234	92	441	119	380	409
			getState	18	4	322	43	14	35
			initialActions	2	1	7	1	3	5
			loadScripts	1688	1328	2173	186	1786	2002
			setupStore	26	7	317	52	19	45
Firefox	Browserify	Home	uiStartup	1381	1186	1992	137	1423	1645
			load	1203	1052	1475	92	1258	1390
			domContentLoaded	1203	1051	1475	92	1257	1390
			domInteractive	120	36	447	66	133	292
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	14	287	32	23	81
			firstReactRender	24	21	35	3	26	29
			getState	16	5	186	32	9	78
			initialActions	0	0	2	0	0	1
			loadScripts	1180	1035	1388	86	1239	1352
			setupStore	12	4	215	28	7	20
	Webpack	Home	uiStartup	1684	1416	2378	203	1761	2047
			load	1445	1221	2018	165	1538	1710
			domContentLoaded	1444	1221	2017	165	1538	1709
			domInteractive	103	34	507	70	98	284
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	85	11	26	40
			firstReactRender	43	30	49	4	46	48
			getState	20	4	250	39	12	107
			initialActions	0	0	2	1	1	1
			loadScripts	1423	1203	1995	164	1520	1691
			setupStore	13	6	257	27	9	40

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2232 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2686 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2014 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 409 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2002 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 292 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 81 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 78 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 1685 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1445 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 103 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 21 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 1424 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2047 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1710 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1709 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 284 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 107 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1691 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 342ms | Sum of p95 exceeds: 965ms
Sum of all benchmark exceeds: 1307ms

…ign-polish

metamaskbot · 2025-06-27T23:06:42Z

Builds ready [7eaee3c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1182 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1182	1049	1318	54	1217	1281
			load	1009	911	1132	51	1041	1098
			domContentLoaded	1003	906	1122	51	1034	1093
			domInteractive	18	14	46	6	17	37
			firstPaint	638	80	1128	401	1014	1094
			backgroundConnect	7	4	29	4	8	11
			firstReactRender	25	17	58	7	26	40
			getState	16	6	80	12	21	32
			initialActions	0	0	1	0	0	1
			loadScripts	797	705	916	51	833	892
			setupStore	9	5	37	5	9	20
	Webpack	Home	uiStartup	2202	1755	2687	209	2307	2647
			load	1686	1302	2213	184	1773	2001
			domContentLoaded	1680	1299	2198	183	1769	1987
			domInteractive	17	12	57	11	14	52
			firstPaint	171	66	750	96	178	331
			backgroundConnect	21	12	45	8	23	40
			firstReactRender	240	88	434	121	381	411
			getState	16	4	273	35	12	31
			initialActions	2	1	8	1	3	4
			loadScripts	1677	1297	2188	182	1767	1975
			setupStore	17	7	304	29	16	25
Firefox	Browserify	Home	uiStartup	1438	1231	2023	154	1494	1802
			load	1249	1086	1557	98	1320	1446
			domContentLoaded	1248	1086	1557	98	1319	1445
			domInteractive	126	37	554	96	118	343
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	98	11	25	40
			firstReactRender	26	22	50	4	26	31
			getState	17	5	255	37	10	49
			initialActions	0	0	2	0	0	1
			loadScripts	1228	1070	1539	97	1296	1420
			setupStore	13	5	169	23	11	60
	Webpack	Home	uiStartup	1603	1388	2725	211	1691	1973
			load	1370	1188	1865	149	1482	1652
			domContentLoaded	1369	1188	1864	149	1482	1652
			domInteractive	95	32	329	53	93	265
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	165	17	25	45
			firstReactRender	42	35	65	4	44	49
			getState	16	5	234	25	13	35
			initialActions	1	0	2	1	1	1
			loadScripts	1348	1170	1838	148	1458	1633
			setupStore	13	5	261	34	8	28

Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2203 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 240 exceeds gate value 235 for chrome webpack home mean firstReactRender
Benchmark value 2648 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 411 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1976 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1438 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1249 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1249 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1802 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 343 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 49 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 60 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 1973 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 265 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 1633 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 101ms | Sum of p95 exceeds: 745ms
Sum of all benchmark exceeds: 846ms

metamaskbot · 2025-06-30T18:58:05Z

Builds ready [c9a85b4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1170 ± 59 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1170	1041	1328	59	1208	1285
			load	1002	905	1118	49	1030	1089
			domContentLoaded	995	899	1107	48	1022	1080
			domInteractive	17	13	58	7	16	41
			firstPaint	682	150	1096	389	1017	1054
			backgroundConnect	8	4	27	4	8	15
			firstReactRender	22	16	51	7	22	39
			getState	14	6	52	8	21	28
			initialActions	0	0	1	0	0	1
			loadScripts	794	702	907	48	821	877
			setupStore	8	4	26	3	8	16
	Webpack	Home	uiStartup	2210	1670	2844	222	2331	2640
			load	1706	1255	2176	183	1793	2014
			domContentLoaded	1700	1250	2162	182	1789	2001
			domInteractive	19	12	209	23	13	62
			firstPaint	173	66	720	88	183	325
			backgroundConnect	25	12	280	37	23	41
			firstReactRender	218	88	472	112	358	397
			getState	11	4	64	8	12	26
			initialActions	2	1	6	1	3	4
			loadScripts	1695	1249	2151	181	1785	1990
			setupStore	14	7	55	7	16	23
Firefox	Browserify	Home	uiStartup	1448	1245	1925	134	1506	1741
			load	1256	1109	1574	91	1335	1418
			domContentLoaded	1254	1109	1573	90	1326	1403
			domInteractive	126	38	458	71	135	328
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	28	15	180	23	26	78
			firstReactRender	26	22	65	5	26	32
			getState	19	6	181	33	10	89
			initialActions	0	0	1	0	0	1
			loadScripts	1232	1088	1548	89	1301	1379
			setupStore	10	4	92	13	9	34
	Webpack	Home	uiStartup	1580	1378	2331	195	1677	2011
			load	1352	1190	1785	140	1452	1639
			domContentLoaded	1351	1190	1784	140	1452	1639
			domInteractive	97	32	458	68	86	280
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	15	228	27	25	57
			firstReactRender	41	32	61	4	43	47
			getState	19	5	251	34	12	88
			initialActions	1	0	1	0	1	1
			loadScripts	1330	1172	1766	139	1432	1621
			setupStore	13	5	260	33	8	31

Benchmark value 2210 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 2640 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 397 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 1991 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1449 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1257 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1255 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 127 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 19 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1233 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1741 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 328 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 78 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 89 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 34 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 27 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 20 exceeds gate value 15 for firefox webpack home mean getState
Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2011 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 280 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 57 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 88 exceeds gate value 32 for firefox webpack home p95 getState
Benchmark value 31 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 136ms | Sum of p95 exceeds: 801ms
Sum of all benchmark exceeds: 937ms

…ign-polish

…sk/metamask-extension into fix/network-manager-design-polish

metamaskbot · 2025-06-30T19:20:38Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-06-30T19:30:07Z

Builds ready [83b79d2]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1172 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1172	1036	1539	71	1218	1286
			load	994	903	1162	51	1032	1077
			domContentLoaded	988	898	1153	51	1026	1070
			domInteractive	18	13	51	8	17	42
			firstPaint	642	73	1126	388	997	1065
			backgroundConnect	7	4	33	3	8	11
			firstReactRender	22	16	42	5	24	36
			getState	16	6	38	7	21	30
			initialActions	0	0	1	0	0	1
			loadScripts	783	697	951	50	821	862
			setupStore	9	5	29	4	9	22
	Webpack	Home	uiStartup	2280	1820	2939	231	2393	2775
			load	1716	1255	2200	196	1850	2069
			domContentLoaded	1709	1250	2176	194	1843	2057
			domInteractive	19	12	134	17	14	62
			firstPaint	165	67	435	74	190	330
			backgroundConnect	30	10	355	43	30	49
			firstReactRender	234	91	428	113	363	408
			getState	19	4	336	34	17	54
			initialActions	3	1	8	1	3	5
			loadScripts	1706	1248	2165	193	1841	2046
			setupStore	26	7	323	47	22	50
Firefox	Browserify	Home	uiStartup	1436	1243	2260	148	1492	1712
			load	1240	1089	1545	88	1313	1377
			domContentLoaded	1240	1089	1545	88	1313	1377
			domInteractive	117	36	437	59	121	275
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	13	84	15	27	66
			firstReactRender	26	22	42	3	26	32
			getState	17	6	328	43	10	58
			initialActions	0	0	2	0	0	1
			loadScripts	1219	1070	1524	87	1290	1356
			setupStore	17	4	191	34	8	82
	Webpack	Home	uiStartup	1641	1396	2182	200	1727	2088
			load	1412	1197	1867	160	1525	1701
			domContentLoaded	1412	1197	1867	160	1524	1700
			domInteractive	111	37	494	82	95	302
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	15	54	6	24	34
			firstReactRender	42	31	69	5	44	48
			getState	14	5	197	19	13	31
			initialActions	1	0	2	1	1	1
			loadScripts	1393	1178	1848	160	1508	1679
			setupStore	12	5	261	26	8	27

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive
Benchmark value 22 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2280 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1716 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1709 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1706 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2775 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2070 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2058 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 408 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 2046 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1437 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1241 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 118 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 17 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1712 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 275 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 58 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 82 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1641 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1413 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1412 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 111 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1393 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2088 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1701 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1700 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 1679 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 304ms | Sum of p95 exceeds: 1189ms
Sum of all benchmark exceeds: 1493ms

gambinish · 2025-06-30T20:17:45Z

Bug: Test Suite Broken by it.only Modifier

The it.only modifier was accidentally committed to a test, causing only that specific test to run and skipping all others in the suite. This breaks full test execution and is typically used for local debugging.

ui/components/multichain/network-manager/components/additional-networks-info/additional-networks-info.test.tsx#L44-L45
Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

👍

fix: AssetListControlBar padding in activity tab

f52e932

metamaskbot added the team-assets label Jun 27, 2025

gambinish changed the title ~~fix: AssetListControlBar padding in activity tab~~ fix: Network Manager style polish Jun 27, 2025

fix: Tighten up cusor on additinal network info, add hover event to a…

5ae154d

…dditional network list item

gambinish requested a review from a team as a code owner June 27, 2025 18:17

Merge branch 'feat/network-manager-UI-2' into fix/network-manager-des…

58d62cc

…ign-polish

Merge branch 'feat/network-manager-UI-2' into fix/network-manager-des…

7eaee3c

…ign-polish

chore: Update additional network info

c9a85b4

This comment was marked as outdated.

Sign in to view

chore: Lint extra space in css file

e652a95

This comment was marked as outdated.

Sign in to view

gambinish and others added 3 commits June 30, 2025 12:04

Merge branch 'feat/network-manager-UI-2' into fix/network-manager-des…

531b9a1

…ign-polish

chore: Remove exclusive test

6d7193e

Merge branch 'fix/network-manager-design-polish' of github.com:MetaMa…

83b79d2

…sk/metamask-extension into fix/network-manager-design-polish

gambinish merged commit 978e30d into feat/network-manager-UI-2 Jun 30, 2025
263 of 269 checks passed

gambinish deleted the fix/network-manager-design-polish branch June 30, 2025 20:14

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Network Manager style polish #33968

fix: Network Manager style polish #33968

gambinish commented Jun 27, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

Uh oh!

gambinish commented Jun 30, 2025

Bug: Test Suite Broken by `it.only` Modifier

Uh oh!

Uh oh!

fix: Network Manager style polish #33968

fix: Network Manager style polish #33968

Conversation

gambinish commented Jun 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

metamaskbot commented Jun 27, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

metamaskbot commented Jun 30, 2025

Uh oh!

Uh oh!

gambinish commented Jun 30, 2025

Bug: Test Suite Broken by it.only Modifier

Uh oh!

Uh oh!

gambinish commented Jun 27, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Jun 27, 2025 •

edited

Loading

Bug: Test Suite Broken by `it.only` Modifier