Skip to content

[WIP]Keystone USB integration #33980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

soralit
Copy link
Contributor

@soralit soralit commented Jun 30, 2025

Description

This PR adds Keystone USB integration.
It includes two steps:

  1. Connect with Keystone
  2. Sign Transactions / Messages with Keystone.

All the operations to communicate with Keystone will open a tab for requesting USB devices, like what Trezor did.

Code changes:

  1. Add Keystone USB Keyring related dependencies.
  2. Implements Connect Hardware UI for Keystone USB connection.
  3. Implements background chrome bridges.
  4. Implements frontend Keystone USB Bridge page for USB communication.

Open in GitHub Codespaces

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 30, 2025
@soralit soralit changed the title [WIP]feat(keystone): basic implementation [WIP]Keystone USB integration Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants