[inlining] increasing accuracy of the code size assessment model #7648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code size measure is simply based on operation count in callee. It will miss the opportunity like
which is always happened for variable setter in OO language.
In this PR, we want to introduce inlining specific measurer to ignore this pattern for better inlining result.
The new measurer will ignore all occurrences of
local.get
that occur in sequence.The behavior of the new measurer will be consistent with that of the old measurer in:
global.get
orxxx.const
local.set
In a word, the new measure want to match this pattern: The function body only contain
local.get $param_n
and trivial consumer operation likexxx.add
xxx.store
if
etc.