Remove parquet_filter and parquet sort
benchmarks
#16730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
filter_pushdown
#16729Rationale for this change
These benchmarks are not used, and are done against synthetic data, and do not seem to measure the impact of filter pushdown or sort in a meaningful way. See additional rationale here:
filter_pushdown
#16729sort_tpch
benchmarkAlso the name
parquet
as the benchmark is misleading as it is supposed to be for parquet filter pushdownFor example of this test adding #16711 (comment)
Let's remove these benchmarks and make a new one using the clickbench queries and data
What changes are included in this PR?
Are these changes tested?
By CI and I tested that bench.sh still works
Are there any user-facing changes?
No (as I don't think these were ever used)