Add clickbench_pushdown
benchmark
#16731
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
filter_pushdown
) by default #3463filter_pushdown
#16729Rationale for this change
In order to enable
filter_pushdown
by default, we need to ensure it doesn't regress existing performanceHowever, it has been very hard to make forward progress on improving filter pushdown because all our benchmarks compare filter pushdown to not filter pushdown, so the bar for change is quite high.
Here is the most recent example:
It seems obvious but the the right metric for improvements to the filter pushdown are comparing when filter pushdown is already on. However, we don't have any such benchmark (see #16729 and #16730 for why the existing benchmarks are not good enough)
What changes are included in this PR?
Add a benchmark (clickbench_pushdown) that turns on filter_pushdown and reorder_filters on
You can run it like this:
`./benchmarks/bench.sh run clickbench_pushdown
Which then invokes
Are these changes tested?
I tested it manually . You can see Q30 increase in time when
--pushdown
is enabled, as expectedwith
--pushdown
:Without pushdown
Are there any user-facing changes?
No this is a development process change only