[FLINK-37867][state/forst] Ensure files of half-uploaded checkpoints are cleaned when using path copying. #26696
+131
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are cleaned when using path copying.
davidradl
reviewed
Jun 18, 2025
| @@ -153,7 +157,8 @@ private HandleAndLocalPath copyFileToCheckpoint( | |||
| private @Nullable StreamStateHandle tryPathCopyingToCheckpoint( | |||
| @Nonnull StreamStateHandle sourceHandle, | |||
| CheckpointStreamFactory checkpointStreamFactory, | |||
| CheckpointedStateScope stateScope) { | |||
| CheckpointedStateScope stateScope, | |||
| CloseableRegistry tmpResourcesRegistry) { | |||
davidradl
reviewed
Jun 18, 2025
| @@ -163,7 +168,10 @@ private HandleAndLocalPath copyFileToCheckpoint( | |||
| List<StreamStateHandle> result = | |||
| checkpointStreamFactory.duplicate( | |||
| Collections.singletonList(sourceHandle), stateScope); | |||
| return result.get(0); | |||
| StreamStateHandle resultStateHandle = result.get(0); | |||
| tmpResourcesRegistry.registerCloseable( | |||
There was a problem hiding this comment.
I think it would be useful to add comments / javadoc around this logic. It is not obvious to me why we are discarding state quietly in a copy method - some comments to detail the thinking here would be good.
I think we are copying information for a failure case. It it worth adding at least a debug around this cleanup.
The Jira says : clean up half-uploaded checkpoints. How do we get half up loaded checkpoints. Is there a case to fix this at source to prevent these half uploaded files from occurring in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request makes ForSt StateBackend register the uploaded state handles to tmpResourcesRegistry when using path copying for checkpointing, thus ensuring the uploaded files can be cleaned up as expected.
Brief change log
CopyDataTransferStrategyregisters the uploaded state handles to tmpResourcesRegistryVerifying this change
This change added tests and can be verified as follows:
DataTransferStrategyTest#testUncompletedCheckpointtests for cleaning files of checkpointsDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation