Remove async from AttachmentAllocator lookup #224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `lookup(hostname:)` method in `AttachmentAllocator` no longer requires async, as it only performs a synchronous dictionary lookup.
Abdullah4345
approved these changes
Jun 22, 2025
dcantah
reviewed
Jun 24, 2025
| @@ -101,7 +101,7 @@ public actor NetworkService: Sendable { | |||
| } | |||
|
|
|||
| let hostname = try message.hostname() | |||
| let index = try await allocator.lookup(hostname: hostname) | |||
| let index = try allocator.lookup(hostname: hostname) | |||
There was a problem hiding this comment.
Because AttachmentAllocator is an actor, callers still need to access every method asynchronously. The removal of the async from the func lookup(hostname: String) definition does not change this, it's solely to mark that that method does not call anything async inside of itself.
There was a problem hiding this comment.
If you get rid of the diff in this file this change LGTM
|
Thank you for the change. When you have time, please update the change. I'll close this and when you have the updated patch, feel free to open a new PR with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lookup(hostname:)method inAttachmentAllocatorno longer requiresasync, as it only performs a synchronous dictionary lookup.