Add container attach/detach support #259
Draft
+2,393
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new `container attach` command that allows users to attach to running containers with terminal support. ## Key changes: - Move stdio management from client to server so that sessions can exist beyond CLI lifetime. - Update stdio to use a ring buffer so attach can get recent history. - Add support for pluggable sandbox transport to enable enhanced testing. - Enable legacy (client driven stdio) and server stdio coexistence. ## CLI Changes - Added `container attach <id>` subcommand for attaching to an existing session. - Added `--legacy-stdio` global flag to let newer clients talk to older servers. - Added `--detach-keys` option to run, exec and attach to set detachment keys (defaulted to ctrl-p,ctrl-q) ## Testing - Added integration tests for attach functionality - Added session management tests - Added fallback/legacy mode tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new
container attachcommand that allows users to attach to running containers with terminal support.Key changes
CLI Changes
container attach <id>command for attaching to an existing session.--legacy-stdioglobal flag to let newer clients talk to older servers.--detach-keysoption to run, exec and attach to set detachment keys (defaulted to ctrl-p,ctrl-q)Testing