Skip to content

Commit 85d624d

Browse files
Riccardo Cipolleschifacebook-github-bot
authored andcommitted
Use HermesExecutorFactory from the internal copy for Meta apps (facebook#52001)
Summary: Pull Request resolved: facebook#52001 Internally we have a private cop of the HermesExecutorFactory that we use to run Hermes related experiments before moving the changes to OSS. The RCTCxxBridge class was wrongly setup and was always falling back to JSC instead of Hermes, when an [`executorClass` was not passed](https://github.com/facebook/react-native/blob/main/packages/react-native/React/CxxBridge/RCTCxxBridge.mm#L467). This change should fix it, properly using the right hermes executor class ## Changelog: [Internal] - Differential Revision: D76594037
1 parent 6b9d931 commit 85d624d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/react-native/React/CxxBridge/RCTCxxBridge.mm

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,11 @@
4646
#import <reactperflogger/BridgeNativeModulePerfLogger.h>
4747

4848
#if USE_HERMES
49+
#if __has_include(<jsireact/HermesExecutorFactory.h>)
50+
#import <jsireact/HermesExecutorFactory.h>
51+
#elif __has_include(<reacthermes/HermesExecutorFactory.h>)
4952
#import <reacthermes/HermesExecutorFactory.h>
53+
#endif
5054
#elif USE_THIRD_PARTY_JSC != 1
5155
#import "JSCExecutorFactory.h"
5256
#endif

0 commit comments

Comments
 (0)