TimeSpan-Style TimeDuration Constructors in C# Bindings #2778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This change adds the following
System.TimeSpan
-style static construction methods toSpacetimeDB.TimeDuration
:static TimeDuration FromMilliseconds(double milliseconds)
static TimeDuration FromSeconds(double seconds)
static TimeDuration FromMinutes(double minutes)
static TimeDuration FromHours(double hours)
static TimeDuration FromDays(double days)
These mirror the equivalently named static methods on
System.TimeSpan
and dramatically improve usability and familiarity for experienced C# users with no more overhead than the user performing the multiplication themselves.Wish I'd thought to do this before v1.1.2 got released. Ah well.
API and ABI breaking changes
None. Convenience methods added in bindings only.
Expected complexity level and risk
1 (potentially up to a low 2 if cleanup is desired elsewhere in the bindings to leverage these new methods).
Testing