Skip to content

Remove incorrect const qualifiers on two imports in bindings.c #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

gefjon
Copy link
Contributor

@gefjon gefjon commented Jun 13, 2025

Description of Changes

datastore_insert_bsatn and datastore_update_bsatn will write back to the row buffer when passed a row with a 0 in an auto_inc column. The Rust imports correctly specify these row pointers as *mut u8, but the C# imports in bindings.c were declaring them as const uint8_t*. This commit removes the incorrect const qualifiers from the row pointer arguments in those declarations.

API and ABI breaking changes

N/a

Expected complexity level and risk

1

Testing

N/a

`datastore_insert_bsatn` and `datastore_update_bsatn` will write back to the row buffer
when passed a row with a 0 in an `auto_inc` column.
The Rust imports correctly specify these row pointers as `*mut u8`,
but the C# imports in `bindings.c` were declaring them as `const uint8_t*`.
This commit removes the incorrect `const` qualifiers
from the row pointer arguments in those declarations.
@gefjon gefjon requested a review from kazimuth June 13, 2025 15:30
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these are morally &mut [u8]

@gefjon gefjon added this pull request to the merge queue Jun 16, 2025
Merged via the queue into master with commit da0757b Jun 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants