Test images: cleanup and centralize #4194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
2025-05-ci-proofing
branch
4 times, most recently
from
57c0321 to
ef657f7
Compare
apostasie
force-pushed
the
2025-05-ci-proofing
branch
17 times, most recently
from
4d4ee15 to
260ee6e
Compare
apostasie
force-pushed
the
2025-05-ci-proofing
branch
from
260ee6e to
21412de
Compare
Closed
AkihiroSuda
reviewed
Jun 20, 2025
AkihiroSuda
reviewed
Jun 20, 2025
apostasie
force-pushed
the
2025-05-ci-proofing
branch
from
21412de to
b43043a
Compare
apostasie
force-pushed
the
2025-05-ci-proofing
branch
from
b43043a to
dd1c643
Compare
|
YAML variant incoming. |
apostasie
force-pushed
the
2025-05-ci-proofing
branch
2 times, most recently
from
3231391 to
29e5871
Compare
fahedouch
reviewed
Jun 21, 2025
|
|
||
| var testImages map[string]TestImage | ||
|
|
||
| func getImage(key string) string { |
There was a problem hiding this comment.
can we have a test for this func getImage :) !
There was a problem hiding this comment.
I think testing test tools is a bit much :) (well, core testing like tigron sure, it should be tested - but this here is just a yaml file getting parsed).
Also this is going to evolve soon with upcoming PRs so let see when this is getting finalized?
There was a problem hiding this comment.
I mean unit test but ok not mandatory regarding the impact
| # Current schema (defined in images_linux.go) allows for ref, tag, (index) digest and platform variants. | ||
| # Right now, digest and variants are not used for anything, but they should / could be in the future. | ||
| # Also note that changing the schema should be easy and straight-forward for now, so, | ||
| # this might evolve in the near future. |
There was a problem hiding this comment.
may be document how to add new images or update existing ones.
There was a problem hiding this comment.
Will do in upcoming PRs once we stabilize the schema?
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
2025-05-ci-proofing
branch
from
29e5871 to
cfb5a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Test images do not currently digest pin when pulling (they should).
Furthermore, test images are peppered all over the place, with some tests using direct references, and some images being defined in platform specific files.
Finally, there is currently no easy mechanism for external scripts to override a specific image version on the fly (eg: for example to test a different registry version on canary).
What this is
This offers to consolidate all test images references inside an embedded file.
Using an embed will allow external tests scripts to more easily manipulate the list and versions (eg: for "canaries") rather than having to parse go source files.
Images in the yaml file can use digest pinning in the future - though right now, we cannot yet do that for a few reasons:
Nevertheless, this is a first step to solving these issues - future PRs to follow.