Skip to content

feat: use stricter regex to filter network labels on the container. #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tushar5526
Copy link
Contributor

@tushar5526 tushar5526 commented Jun 13, 2025

This allows us to skip double-checking the network names on the container.

Related to #4282

Network related labels on a Container are stored as follows:

"nerdctl/networks": "[\"net1\",\"net1-1\"]"

The new regex in this PR, exactly matches the network name, taking in account the \ and "

@tushar5526 tushar5526 force-pushed the use-stricter-regex-filter-match-network-labels branch 3 times, most recently from e03655b to e5ab123 Compare June 13, 2025 21:21
@tushar5526
Copy link
Contributor Author

It does not look like the failing test is related to the changes made here. Are they flaky?

@apostasie
Copy link
Contributor

Yes.

canary failures -> #4318
gomodjail -> #3971

@AkihiroSuda
Copy link
Member

Could you try rebasing?

@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone Jun 19, 2025
This allows us to skip double checking the network names on the
container with an additional helper function.

Signed-off-by: Tushar Gupta <codingid6@gmail.com>
@tushar5526 tushar5526 force-pushed the use-stricter-regex-filter-match-network-labels branch from e5ab123 to b2f3b6c Compare June 21, 2025 10:58
@tushar5526
Copy link
Contributor Author

Rebase done.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 87a6ab9 into containerd:main Jun 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants