feat: allow regexp name filters to match docker #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <me@jedevc.com>
apostasie
reviewed
Jun 19, 2025
| @@ -304,6 +304,42 @@ func TestContainerListWithFilter(t *testing.T) { | |||
| return nil | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Maybe break down TestContainerListWithFilter into multiple different test functions (this one really feels like a mouthful now).
Alternatively, just bump up cognitive-complexity in golangci.yml.
Tip: call make lint to have the linter run locally if you didn't know that.
|
@jedevc nice! Windows failure may be just a fluke (hcsshim is not exactly a parangon of stability...) - let see what happens when it re-runs. Otherwise, LGTM (pending lint fix). |
apostasie
approved these changes
Jun 19, 2025
Signed-off-by: Justin Chadwell <me@jedevc.com>
|
CI failure is unrelated (#4237). @AkihiroSuda @Shubhranshu153 @fahedouch for maintainers review. |
Shubhranshu153
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4323.