-
Notifications
You must be signed in to change notification settings - Fork 10
Elevation token does not work for dark mode #4125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@andre-bartak We don't provide a shadow for dark-mode, because it would look like a glow effect. Every component should have an additional border to seperate the content from other elements. Maybe @leape can answer this in detail |
You've already summarized it well, Nico. @nmerget in the drawer, however, the border is missing, i.e. we absolutely have to add it! |
@andre-bartak But you also use the checkbox, right? So the elevation is not the only indicator for the selection if I understand it correctly. From this perspective, the indicator for the selected card would be there for dark mode. |
You are right @leape , the elevation just enhances the selection which is already indicated by the checkbox. |
Uh oh!
There was an error while loading. Please reload this page.
Which generators are impacted?
Reproduction case
The
--db-elevation
tokens (like e.g.--db-elevation-md
) seems to have a fixed dark color for the shadow.In dark mode this shadow is not visible and the elevation does not work.
Compare to e.g. the shadow defined for
.db-drawer .db-drawer-container
:https://design-system.deutschebahn.com/core-web/version/v2.0.4/components/layout/drawer/overview
Expected Behaviour
The elevation effect should be available in dark mode
Screenshots
No response
Browser version
None
Add any other context about the problem here.
No response
The text was updated successfully, but these errors were encountered: