-
Notifications
You must be signed in to change notification settings - Fork 10
chore: update configurations #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…line EOF, ignore node_modules
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-update-configurations |
@@ -1,6 +1,8 @@ | |||
{ | |||
"trailingComma": "none", | |||
"bracketSpacing": true, | |||
"printWidth": 150, | |||
"tabWidth": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tabWidth": 2 is even already the default for prettier, why do you set this again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly setting tabWidth: 2 ensures clear documentation for all contributors, even if it’s the default. If we do not want this, I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tabWidth": 2, |
Even though that it seems to be a good intention, I'm struggling to start with doing this, as we would probably have to set further default aspects for consistency.
prettier: true, | ||
ignores: [ | ||
'./showcases/nuxt-showcase/**', | ||
'./packages/migration/**', | ||
'./packages/foundations/**' | ||
], | ||
ignores: ['./showcases/nuxt-showcase/**', './packages/migration/**', './packages/stylelint/**', './packages/foundations/**'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why should we ignore the stylelint
-plugin-package in total ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the linting is only meant for the component-package and the stylelint-package was forgotten to be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier: true, | |
ignores: [ | |
'./showcases/nuxt-showcase/**', | |
'./packages/migration/**', | |
'./packages/foundations/**' | |
], | |
ignores: ['./showcases/nuxt-showcase/**', './packages/migration/**', './packages/stylelint/**', './packages/foundations/**'], | |
ignores: [ | |
'./showcases/nuxt-showcase/**', | |
'./packages/migration/**', | |
'./packages/foundations/**' | |
], |
let's revert it.
@@ -11,7 +11,7 @@ | |||
"bugs": { | |||
"url": "https://github.com/db-ux-design-system/core-web/issues" | |||
}, | |||
"author": "", | |||
"author": "Deutsche Bahn AG", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"author": "Deutsche Bahn AG", | |
"author": "DB Systel GmbH", |
aligned with our copyright entry.
@michaelmkraus I added some comments. |
Proposed changes
This pull request introduces several configuration improvements across the project. The following commits have been applied:
Types of changes