Skip to content

fix: sass mixed-decls deprecation #4098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

fix: sass mixed-decls deprecation #4098

merged 3 commits into from
Apr 29, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Apr 23, 2025 •
edited
Loading

Proposed changes

  • Add --fatal-deprecation=mixed-decls to force an error for sass, this allows the pipeline to fail if we use a deprecated feature
  • fixed issues from mixed-decls

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner April 23, 2025 06:58
@nmerget nmerget moved this to 👀 In review in UX Engineering Team Backlog Apr 23, 2025
@nmerget nmerget enabled auto-merge (squash) April 23, 2025 06:58
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-sass-mixed-decls-deprecation

@github-actions github-actions bot added 📦foundations Changes inside foundations folder 🧱components Changes inside components folder labels Apr 23, 2025
@mfranzke
Copy link
Collaborator

mfranzke commented Apr 23, 2025 •
edited
Loading

Add --fatal-deprecation=mixed-decls to prevent warnings in sass

@nmerget to my understanding, --fatal-deprecation=mixed-decls isn't about preventing/silencing warnings (--silence-deprecation=mixed-decls would be doing this, but we would not want to do this at all), but increase the output level from warning to error. So I see a mismatch in between the description and solution of this PR.

@nmerget nmerget changed the title fix: issue with sass mixed-decls deprecation fix: sass mixed-decls deprecation Apr 23, 2025
@nmerget
Copy link
Collaborator Author

nmerget commented Apr 23, 2025

Add --fatal-deprecation=mixed-decls to prevent warnings in sass

@nmerget to my understanding, --fatal-deprecation=mixed-decls isn't about preventing/silencing warnings (--silence-deprecation=mixed-decls would be doing this, but we would not want to do this at all), but increase the output level from warning to error. So I see a mismatch in between the description and solution of this PR.

I updated the description

mfranzke
mfranzke reviewed Apr 25, 2025
View reviewed changes
@mfranzke mfranzke requested a review from Copilot April 25, 2025 05:03
Copilot
Copilot AI reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (6)
  • packages/components/package.json: Language not supported
  • packages/components/src/components/switch/switch.scss: Language not supported
  • packages/components/src/styles/internal/_form-components.scss: Language not supported
  • packages/foundations/package.json: Language not supported
  • packages/foundations/scss/defaults/default-icons.scss: Language not supported
  • packages/foundations/scss/icons/_icon-helpers.scss: Language not supported

@mfranzke mfranzke linked an issue Apr 28, 2025 that may be closed by this pull request
mixed-decls deprecation warnings #4119
Closed
7 tasks
@nmerget nmerget merged commit 2cdc821 into main Apr 29, 2025
73 checks passed
@nmerget nmerget deleted the fix-sass-mixed-decls-deprecation branch April 29, 2025 12:56
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@mfranzke mfranzke

Assignees
No one assigned
Labels
🧱components Changes inside components folder 📦foundations Changes inside foundations folder
Projects
UX Engineering Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mixed-decls deprecation warnings
2 participants
@nmerget @mfranzke