Skip to content

chore: enable variables for Shadow DOM host as well #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

chore: enable variables for Shadow DOM host as well #4126

merged 2 commits into from
Apr 30, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Apr 29, 2025 •
edited by mfranzke
Loading

Proposed changes

Styles weren't usable in case that CSS get's included within a Web Component and needs to get scoped to Shadow DOM.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner April 29, 2025 15:49
@nmerget nmerget moved this to 👀 In review in UX Engineering Team Backlog Apr 29, 2025
@github-actions github-actions bot added the 📦foundations Changes inside foundations folder label Apr 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-enable-variables--host

@nmerget nmerget enabled auto-merge (squash) April 29, 2025 15:49
@mfranzke mfranzke changed the title chore: enable variables for shadow dom host as well chore: enable variables for Shadow DOM host as well Apr 30, 2025
@nmerget nmerget merged commit ff8a694 into main Apr 30, 2025
73 checks passed
@nmerget nmerget deleted the chore-enable-variables--host branch April 30, 2025 07:12
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke

Assignees
No one assigned
Labels
📦foundations Changes inside foundations folder
Projects
UX Engineering Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke