refactor: replace title-attribute for removable tag with DBTooltip
#4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-remove-tag-title |
mfranzke
moved this from 👀 In review
to ready for release
in UX Engineering Team Backlog
mfranzke
previously approved these changes
May 16, 2025
|
@nmerget this one is "ready for release", let's not activate "auto-merge". |
mfranzke
changed the title
title-attribute for remove tag with DBTooltip
mfranzke
changed the title
title-attribute for remove tag with DBTooltiptitle-attribute for removable tag with DBTooltip
|
@nmerget one pipeline step is still failing for this issue. |
mfranzke
reviewed
May 23, 2025
showcases/screen-reader/__snapshots__/macos/webkit/DBTag-behavior-1.txt
Outdated
Show resolved
Hide resolved
mfranzke
previously approved these changes
May 26, 2025
# Conflicts: # packages/components/src/components/tag/tag.lite.tsx
mfranzke
reviewed
May 26, 2025
mfranzke
approved these changes
May 26, 2025
github-project-automation
bot
moved this from ready for release
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #4203
That for introduced
variant="description"|"label"property for the DBTooltip component, that controls whether tooltip content is either connected as a complementary description or as a label (overwriting the inner, visible content).Types of changes
Further comments