Skip to content

feat: add new colors light-green and burgundy #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

michaelmkraus
Copy link
Contributor

@michaelmkraus michaelmkraus commented May 22, 2025

Proposed changes

  • add new color burgundy and light-green

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Copy link
Contributor

@michaelmkraus michaelmkraus marked this pull request as ready for review May 22, 2025 13:31
@michaelmkraus michaelmkraus requested a review from mfranzke as a code owner May 22, 2025 13:31
@michaelmkraus michaelmkraus merged commit 77c9cb9 into main May 22, 2025
73 checks passed
@michaelmkraus michaelmkraus deleted the feat-add-colors-burgundy-green branch May 22, 2025 13:31
@mfranzke
Copy link
Collaborator

mfranzke commented May 23, 2025

@michaelmkraus @nmerget these are most likely planned for release 2.2.0, not 2.1.0; so we need to revert them from main again.

@mfranzke mfranzke restored the feat-add-colors-burgundy-green branch May 23, 2025 04:27
@mfranzke mfranzke added this to the 2.2.0 milestone May 23, 2025
@nmerget
Copy link
Collaborator

nmerget commented May 23, 2025

If @leape is ready, we could release it in 2.1.0 as well

@mfranzke
Copy link
Collaborator

mfranzke commented May 23, 2025

If @leape is ready, we could release it in 2.1.0 as well

exactly, that's what we need to find out later. But as it's part of the current sprint, some issues are currently still in progress, https://github.com/db-ux-design-system/core-team/issues/254 is defined for milestone 2.2.0 and we haven't talked about this within our final release planning meeting yesterday, I would doubt that we could make it for 2.1.0. But I will discuss this.

@mfranzke mfranzke deleted the feat-add-colors-burgundy-green branch May 23, 2025 13:40
@mfranzke mfranzke modified the milestones: 2.2.0, 2.1.0 Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants