Skip to content

fix: typescript issue for DBIcon for variant by allowing all strings #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented May 23, 2025

Proposed changes

closes #4226
closes #3949

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner May 23, 2025 07:28
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-db-icon-variant-ts

@nmerget nmerget enabled auto-merge (squash) May 23, 2025 07:48
@nmerget nmerget merged commit a1070d4 into main May 23, 2025
74 checks passed
@nmerget nmerget deleted the fix-db-icon-variant-ts branch May 23, 2025 07:59
@mfranzke mfranzke self-assigned this May 23, 2025
@mfranzke mfranzke added 🍄🆙improvement New feature or request 🐛bug Something isn't working labels May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🍄🆙improvement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

DBIcon: Icons beyond the BaseIcons aren't working DBIcon: Filled Variant not working
2 participants