IssueFix/May round 2 & Menu插件大强化 #2167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 修复画布isSilentMode变化时,菜单DOM的显隐不跟随变化问题 2. 修复菜单项变化时,菜单面板不实时更新问题 3. 菜单项支持配置禁用状态 fix #1573 4. 菜单支持指定icon并调整样式
|
DymoneLewis
commented
May 29, 2025
| @@ -110,138 +139,16 @@ class Menu { | |||
| }, | |||
| }, | |||
| ] | |||
| this.menuTypeMap?.set(DefaultSelectionMenuKey, DefaultSelectionMenu) | |||
There was a problem hiding this comment.
非private的方法统一挪到private方法后面了，所以这里看起来删了写代码
（无他，就是两种方法混着写看起来很难受
|
666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2013 #1573
并中幅度优化菜单插件功能，大幅度优化菜单相关的文档和demo
二编：看了下diff，还是大强化吧