Skip to content

Draft #49636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft #49636

wants to merge 1 commit into from

Conversation

Youssef1313
Copy link
Member

This is a draft for me to see if there is test coverage for this check, and what it exactly affects.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Jul 12, 2025

@baronfel @dsplaisted There are no test failures here, and it's not yet clear to me what scenario breaks. Can we please have a clear test coverage so that we understand the impact?

The check so far doesn't make much sense to me. Part of the condition is:

'$(SelfContained)' == 'true' or
   ('$(_IsPublishing)' == 'true' and
      (
        '$(PublishReadyToRun)' == 'true' or
        '$(PublishSingleFile)' == 'true' or
        '$(PublishAot)' == 'true'
      )
   )

I don't think users will try to publish VSTest test projects that way, and I feel that a break here in .NET 10 to help us move forward with proper MTP support is fine. In a very rare case where a user is impacted, I think they should explicitly set UseCurrentRuntimeIdentifier in their VSTest project themselves, instead of the SDK trying to magically hack around stuff and breaking MTP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant