Address when scores can be very large in osq score test #129592
Merged
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
benwtrent
added
>test
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
| float diff = scores1[j] - scores2[j]; | ||
| assertThat( | ||
| "defaultScores: " + scores1[j] + " bulkScores: " + scores2[j], | ||
| diff / scores1[j], |
There was a problem hiding this comment.
does this not need an Math.abs so as to be Math.abs(diff) / scores1[j]?
benwtrent
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a static
diffor epsilon just doesn't work for this test as the scores can be very large, but relatively close.Maybe there is a simpler way, but my mind wasn't wanting to "math" very much.
For example, the seed that this previously failed on had scores like
1.726524E9and1.7265239E9, which, given their size, are really close together (within 128). But a static epsilon wouldn't capture that.closes: #128485