export adapter utils for use in building external adapters #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. Hopefully this gets merged ASAP, I'm blocked by this. |
|
Close as fixed by 47ae5fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the /adapter/utils file to the list of exports in package.json.
Currently the node adapter is broken on Elysia 1.3. Some of us have attempted to fix it, but it seems that having access to import the adapter utils will be necessary to do so without copying or rebuilding a bunch of code. Exporting the these utils in "package.json should allow the node adapter to access those utils and reuse the code that is used to build the built-in adapter.