[Next] Kill mixins #20935
Open
[Next] Kill mixins #20935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Estimated Asset SizesDiff --- main/out.txt 2025-06-13 02:23:26.000000000 +0000
+++ pr/./pr-15641275241/out.txt 2025-06-13 18:18:40.000000000 +0000
@@ -1,59 +1,59 @@
-╔═══════╤══════════╤═══════════╗
-║ │ Min │ Gzip ║
-╟───────┼──────────┼───────────╢
-║ Total │ 409.3 KB │ 228.73 KB ║
-╚═══════╧══════════╧═══════════╝
+╔═══════╤═══════════╤═══════════╗
+║ │ Min │ Gzip ║
+╟───────┼───────────┼───────────╢
+║ Total │ 372.71 KB │ 207.15 KB ║
+╚═══════╧═══════════╧═══════════╝
-╔══════════════════════╤═══════════╤═══════════╗
-║ @ember/* │ Min │ Gzip ║
-╟──────────────────────┼───────────┼───────────╢
-║ Total │ 239.69 KB │ 147.05 KB ║
-╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 35.92 KB │ 25.65 KB ║
-║ application │ 12.83 KB │ 7.58 KB ║
-║ array │ 12.66 KB │ 7.32 KB ║
-║ canary-features │ 304 B │ 405 B ║
-║ component │ 1.07 KB │ 995 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.4 KB │ 7.87 KB ║
-║ deprecated-features │ 31 B │ 77 B ║
-║ destroyable │ 561 B │ 383 B ║
-║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 615 B ║
-║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 605 B ║
-║ object │ 33.78 KB │ 20.82 KB ║
-║ owner │ 159 B │ 178 B ║
-║ renderer │ 385 B │ 344 B ║
-║ routing │ 58.05 KB │ 33.12 KB ║
-║ runloop │ 2.2 KB │ 1.41 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 396 B │ 342 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.81 KB │ 30.44 KB ║
-║ template-factory │ 94 B │ 160 B ║
-║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.51 KB ║
-║ version │ 55 B │ 131 B ║
-╚══════════════════════╧═══════════╧═══════════╝
+╔══════════════════════╤══════════╤═══════════╗
+║ @ember/* │ Min │ Gzip ║
+╟──────────────────────┼──────────┼───────────╢
+║ Total │ 203.1 KB │ 125.49 KB ║
+╟──────────────────────┼──────────┼───────────╢
+║ -internals │ 28.02 KB │ 20.01 KB ║
+║ application │ 12.35 KB │ 7.51 KB ║
+║ array │ 1.38 KB │ 1.37 KB ║
+║ canary-features │ 304 B │ 405 B ║
+║ component │ 1.07 KB │ 970 B ║
+║ controller │ 1.24 KB │ 1.12 KB ║
+║ debug │ 10.98 KB │ 7.79 KB ║
+║ deprecated-features │ 31 B │ 77 B ║
+║ destroyable │ 561 B │ 383 B ║
+║ enumerable │ 0 B │ 0 B ║
+║ helper │ 823 B │ 583 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 669 B │ 598 B ║
+║ object │ 19.48 KB │ 12.06 KB ║
+║ owner │ 159 B │ 178 B ║
+║ renderer │ 385 B │ 328 B ║
+║ routing │ 57.42 KB │ 33.12 KB ║
+║ runloop │ 2.2 KB │ 1.33 KB ║
+║ service │ 859 B │ 755 B ║
+║ template │ 396 B │ 340 B ║
+║ template-compilation │ 429 B │ 366 B ║
+║ template-compiler │ 57.81 KB │ 30.44 KB ║
+║ template-factory │ 94 B │ 160 B ║
+║ test │ 923 B │ 627 B ║
+║ utils │ 3.17 KB │ 3.2 KB ║
+║ version │ 55 B │ 131 B ║
+╚══════════════════════╧══════════╧═══════════╝
╔═════════════════╤═══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼───────────┼──────────╢
-║ Total │ 169.61 KB │ 81.69 KB ║
+║ Total │ 169.61 KB │ 81.67 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable │ 2.7 KB │ 1.35 KB ║
║ encoder │ 596 B │ 653 B ║
║ env │ 38 B │ 87 B ║
║ global-context │ 886 B │ 545 B ║
-║ manager │ 12.19 KB │ 5.44 KB ║
+║ manager │ 12.19 KB │ 5.41 KB ║
║ node │ 2.71 KB │ 1.81 KB ║
║ opcode-compiler │ 29.89 KB │ 13.23 KB ║
║ owner │ 159 B │ 202 B ║
║ program │ 7.1 KB │ 3.63 KB ║
║ reference │ 5.51 KB │ 3.18 KB ║
║ runtime │ 95.26 KB │ 42.51 KB ║
-║ tracking │ 989 B │ 972 B ║
+║ tracking │ 989 B │ 981 B ║
║ util │ 3.03 KB │ 2.29 KB ║
║ validator │ 6 KB │ 3.72 KB ║
║ vm │ 784 B │ 798 B ║Details
|
13 tasks
wagenet
commented
Jun 13, 2025
| 'this = null should be handled on Mixin.toString() call' | ||
| ); | ||
| } | ||
| // TODO: Do we want to test for this case? |
There was a problem hiding this comment.
If we want to keep supporting Namespace, we should update this test to not use Mixins.
wagenet
commented
Jun 13, 2025
packages/@ember/object/tests/computed/dependent-key-compat-test.js
Outdated
Show resolved
Hide resolved
wagenet
commented
Jun 13, 2025
wagenet
commented
Jun 13, 2025
wagenet
commented
Jun 13, 2025
wagenet
commented
Jun 13, 2025
wagenet
commented
Jun 13, 2025
| @@ -7,6 +7,7 @@ import { getHash } from './lib/location-utils'; | |||
| @module @ember/routing/hash-location | |||
| */ | |||
|
|
|||
| // TODO: Update these docs | |||
There was a problem hiding this comment.
We need to update these and the docs for other locations.
wagenet
commented
Jun 13, 2025
| @@ -209,6 +209,7 @@ export function join(methodOrTarget: any, methodOrArg?: any, ...additionalArgs: | |||
| return _backburner.join(methodOrTarget, methodOrArg, ...additionalArgs); | |||
| } | |||
|
|
|||
| // TODO: Update this example | |||
There was a problem hiding this comment.
This example should be updated.
wagenet
commented
Jun 13, 2025
| assert | ||
| ) { | ||
| assert.expect(3); | ||
| // TODO: We've now broken this behavior. We should make sure we're ok with that |
wagenet
commented
Jun 13, 2025
| 'You passed in `[{"commitBy":{"replace":true}}]` as the value for `queryParams` but `queryParams` cannot be an Array' | ||
| ); | ||
| } | ||
| // TODO: Is it ok to break merged queryParams? |
wagenet
commented
Jun 13, 2025
| @@ -344,7 +341,6 @@ module.exports = { | |||
| 'promise', | |||
| 'pushState', | |||
| 'queryParams', | |||
| 'queryParamsDidChange', | |||
There was a problem hiding this comment.
We should investigate this.
wagenet
commented
Jun 13, 2025
| @@ -228,7 +248,8 @@ QUnit.module('Ember.Application - visit() Integration Tests', function (hooks) { | |||
| ]); | |||
| }); | |||
|
|
|||
| QUnit.test('Resource-discovery setup', function (assert) { | |||
| // FIXME: Figure out how to make this test run without `.extends` | |||
There was a problem hiding this comment.
We need to decide if this, and subsequent tests, should be updated and kept around.
NullVoxPopuli
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow need to be deprecated before this can land in main:
EmberObject#reopenEmberObject#reopenClassEmberObject#extend