-
Notifications
You must be signed in to change notification settings - Fork 719
Update ERC-7743: Complete Architecture Overhaul - Direct Author Minting + Platform Fee System + Payment Fixes #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
ERC-7743 is final and may no longer be modified. You may open a new proposal, with a different number, if you'd like to continue development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major architectural overhaul of ERC-7743 that transforms it from admin-controlled minting to fully decentralized direct author minting, adds a comprehensive platform fee system for sustainable monetization, and fixes the fundamentally broken payment system that required contracts to pay from empty balances.
🚀 Major Architecture Changes
🔧 Direct Author Minting (Security & Decentralization)
💰 Platform Fee System (Monetization)
🔧 Core Payment System Fix
address(this).balance
(always fails)msg.value
to cover all fees🆕 New Features Added
Minting Functions
provide()
now allows authors to mint directly to themselvesmintTokenTo()
- simplified to direct author minting onlyPlatform Fee Management
Enhanced Transfer System
transferFrom()
: Free transfers (ERC-721 compatibility)transferFromWithPayment()
: Paid transfers with provider royalties + platform feessmartTransfer()
: Now handles both provider and platform fees automaticallygetTransferCost()
: Returns total cost (provider fee + platform fee)getTransferCostBreakdown()
: Detailed fee breakdown for transparencyNew Events
💡 Enhanced Fee Logic Matrix
🏗️ Platform Fee Calculation
Total Cost = Provider Fee + Platform Fee
Platform Fee = Provider Fee × Platform Fee Ratio ÷ 10,000
Example: Provider Fee = 1 ETH, Platform Fee = 2.5% → Total = 1.025 ETH
🔒 Security Enhancements
📖 Updated Specification
✅ Benefits Summary
transferFrom()
still works🧪 Testing Coverage
✅ Tested direct author minting functionality
✅ Verified platform fee calculation and distribution
✅ Confirmed dual fee payment system works correctly
✅ Tested provider fee exemption logic
✅ Verified smart transfer automatic fee detection
✅ New: Tested platform fee management functions
✅ New: Verified fee recipient updates work correctly
✅ New: Confirmed maximum fee limits are enforced
📁 Files Changed
contracts/src/DigitalAsset.sol
- Complete overhaul with platform feescontracts/src/MONFT.sol
- Removed admin-only minting restrictionscontracts/src/IDigitalAsset.sol
- Updated interface with platform fee functionsERCs/ERCS/erc-7743.md
- Comprehensive specification updateERCs/assets/erc-7743/DigitalAsset.sol
- Reference implementation updatedERCs/assets/erc-7743/MONFT.sol
- Reference implementation updatedERCs/assets/erc-7743/IDigitalAsset.sol
- Reference interface updated🎯 Migration Impact
This is a breaking change that transforms ERC-7743 from a centralized admin-controlled system to a fully decentralized direct author minting system with sustainable platform monetization. The changes make the standard production-ready for real-world deployment while maintaining creator-friendly policies.
Previous implementations will need to migrate to support:
This update makes ERC-7743 secure (no admin keys), decentralized (direct author control), sustainable (platform fees), and creator-friendly (provider exemptions) - a complete solution for digital asset tokenization platforms.