Skip to content

chore(fw): raise an exception if an opcode recieves an invalid keyword argument #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(fw): raise an exception if an opcode recieves an invalid keyword argument #1739

wants to merge 6 commits into from

Conversation

richardgreg
Copy link
Contributor

🗒️ Description

  • Add kwargs validation in Opcode.call method in opcode.py
  • Add test coverage in test_vm.py for validation behavior

🔗 Related Issues

Fixes #1716

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Added an entry to CHANGELOG.md.

@richardgreg richardgreg force-pushed the chore/opcode-kwargs-validation branch from 5cae01a to b5b590c Compare June 12, 2025 15:50
@richardgreg
chore(fw): raise an exception if an opcode recieves an invalid keywor…
2d0409c 
…d argument

* Add kwargs validation in Opcode.__call__ method in opcode.py
* Add test coverage in test_vm.py for validation behavior
@richardgreg richardgreg force-pushed the chore/opcode-kwargs-validation branch from b5b590c to 2d0409c Compare June 14, 2025 07:14
marioevz
marioevz approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

This actually seems to have caught some actual issues in some tests, and I took the liberty to include fixes to some of the failing tests to get this merged.

@richardgreg
Copy link
Contributor Author

Thanks for implementing this!

This actually seems to have caught some actual issues in some tests, and I took the liberty to include fixes to some of the failing tests to get this merged.

Thanks for the assist.

It was rewarding seeing my implementation catch those hidden bugs

@marioevz
Copy link
Member

I'm working on a parallel PR to fix the CI issues in this PR: #1761

As soon as we merge that one we should be able to rebase this PR and the CI should pass 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(fw): raise an exception if an opcode recieves an invalid keyword argument
2 participants
@richardgreg @marioevz