Skip to content

fix(github,tests): Split coverage workflow, add coverage_missed_reason to more ported tests #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 17, 2025

🗒️ Description

Coverage workflow changes

The coverage workflow is now split into several scripts in order to make the flow more modular and approachable.

This includes the following new script files:

  • .github/scripts/check_changed_tests.sh
  • .github/scripts/fill_introduced_tests.sh
  • .github/scripts/fill_prepatched_tests.sh
  • .github/scripts/parse_ported_tests.sh
  • .github/scripts/run_coverage.sh
  • .github/scripts/verify_coverage.sh

Tests with new "Coverage missing reason"

  • tests/constantinople/eip1014_create2/test_create_returndata.py
  • tests/frontier/create/test_create_one_byte.py

Fixed tests where the coverage missing was an actual problem

  • tests/frontier/identity_precompile/test_identity_returndatasize.py
  • tests/frontier/precompiles/test_precompiles.py

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore labels Jun 17, 2025
@marioevz marioevz force-pushed the add-coverage-missed-reason-to-more-tests branch from 6cc4656 to 03e8363 Compare June 18, 2025 10:41
@marioevz marioevz changed the title fix(tests): Add coverage_missed_reason to more ported tests. fix(github,tests): Split coverage workflow, add coverage_missed_reason to more ported tests Jun 18, 2025
@marioevz marioevz force-pushed the add-coverage-missed-reason-to-more-tests branch 4 times, most recently from 3758797 to b62e15d Compare June 18, 2025 16:49
@marioevz marioevz marked this pull request as ready for review June 18, 2025 16:49
@marioevz marioevz force-pushed the add-coverage-missed-reason-to-more-tests branch 2 times, most recently from 3dc5675 to c862ab6 Compare June 18, 2025 17:07
marioevz added 2 commits June 19, 2025 09:45
fix(tests): Add coverage missing reasons
fix(tests): Test using incorrect keyword argument
@marioevz marioevz force-pushed the add-coverage-missed-reason-to-more-tests branch from c862ab6 to 5fd4672 Compare June 19, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant