Skip to content

feat(consume): add consume enginex simulator #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

danceratopz
Copy link
Member

🗒️ Description

Adds a simulator that runs BlockchainEngineXFixture against clients.

Running The Simulator & Initial results

I've been testing locally with a subset of 1846 tests that create 29 groups from Cancun:

uv run fill --output=fixtures --clean -x -m "not zkevm and not slow" tests/cancun --fork=Cancun --evm-bin=../evmone/build/bin/evmone-t8n -n 8 --generate-pre-alloc-groups

Then consume against a hive dev server:

uv run consume enginex --input=fixtures-cancun --durations=5 --dist=loadgroup -n 8 --enginex-fcu-frequency=0

Results for 1846 tests with 29 groups (=^ 29 client initializations):

  • reth: 85.37s (0:01:25).
  • besu: 361.71s (0:06:01).
    (client versions at Pectra Fork).

FCU Behavior

# Disable all FCUs (fastest execution)
uv run consume enginex --enginex-fcu-frequency=0 fixtures/

# FCU every test (current behavior)  
uv run consume enginex --enginex-fcu-frequency=1 fixtures/

# FCU every 3rd test per pre-allocation group
uv run consume enginex --enginex-fcu-frequency=3 fixtures/

Xdist Behavior

Tests get distributed to xdist worker by pre-allocation group using loadgroup:

uv run consume enginex --input=fixtures-cancun --durations=5 --dist=loadgroup -n 8 --enginex-fcu-frequency=0

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Plugins called 'conftest' are registered automatically if in a sub-path to a test. This rename requires an explicit registration, which is specified by defining the `pytest_plugins` variable in 'engine/conftest.py', respectively, 'rlp/conftest.py'.
These are fixtures that can also be shared by multi-client architecture simulators.
… groups' 1/2

Terminology:
- 'shared pre-allocation' → 'pre-allocation groups'
- 'shared pre-state' → 'pre-allocation groups'

Flags:
-  `--generate-shared-pre` -> `--generate-grouped-pre-allocs`
-  `--use-shared-pre` -> `--use-grouped-pre-allocs`

Method names updated:
- `update_shared_pre_state` → `update_pre_alloc_groups`
- `compute_shared_pre_alloc_hash` → `compute_pre_alloc_group_hash`
- `shared_pre_alloc_folder_path` → `grouped_pre_allocs_folder_path`
Rename command-line flags to align with function and class naming:
- --generate-grouped-pre-allocs → --generate-pre-alloc-groups
- --use-grouped-pre-allocs → --use-pre-alloc-groups

This improves consistency with PreAllocGroups class and related
method names throughout the codebase. Updated all flag definitions,
config.getoption() calls, property names, and documentation.
@danceratopz danceratopz self-assigned this Jun 18, 2025
@danceratopz danceratopz added type:feat type: Feature scope:consume Scope: Consume command suite labels Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant