-
Notifications
You must be signed in to change notification settings - Fork 147
feat(consume): add consume enginex
simulator
#1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
danceratopz
wants to merge
23
commits into
main
Choose a base branch
from
feat/consume-enginex
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,195
−758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins called 'conftest' are registered automatically if in a sub-path to a test. This rename requires an explicit registration, which is specified by defining the `pytest_plugins` variable in 'engine/conftest.py', respectively, 'rlp/conftest.py'.
These are fixtures that can also be shared by multi-client architecture simulators.
… groups' 1/2 Terminology: - 'shared pre-allocation' → 'pre-allocation groups' - 'shared pre-state' → 'pre-allocation groups' Flags: - `--generate-shared-pre` -> `--generate-grouped-pre-allocs` - `--use-shared-pre` -> `--use-grouped-pre-allocs` Method names updated: - `update_shared_pre_state` → `update_pre_alloc_groups` - `compute_shared_pre_alloc_hash` → `compute_pre_alloc_group_hash` - `shared_pre_alloc_folder_path` → `grouped_pre_allocs_folder_path`
Rename command-line flags to align with function and class naming: - --generate-grouped-pre-allocs → --generate-pre-alloc-groups - --use-grouped-pre-allocs → --use-pre-alloc-groups This improves consistency with PreAllocGroups class and related method names throughout the codebase. Updated all flag definitions, config.getoption() calls, property names, and documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a simulator that runs
BlockchainEngineXFixture
against clients.Running The Simulator & Initial results
I've been testing locally with a subset of 1846 tests that create 29 groups from Cancun:
Then consume against a hive dev server:
Results for 1846 tests with 29 groups (=^ 29 client initializations):
reth
: 85.37s (0:01:25).besu
: 361.71s (0:06:01).(client versions at Pectra Fork).
FCU Behavior
Xdist Behavior
Tests get distributed to xdist worker by pre-allocation group using
loadgroup
:🔗 Related Issues
BlockchainEngineReorgFixture
#1706✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.