Skip to content

Pass count into re.sub() as a named argument in isolate_tests.py to fix the deprecation warning #16060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 21, 2025

PR Summary

This small PR resolves the regex library warnings showing in Python3.11:

DeprecationWarning: 'count' is passed as positional argument

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@matheusaaguiar
Copy link
Collaborator

@matheusaaguiar anything else is needed from my side? thanks 🙌

Sorry for the late response @emmanuel-ferdman. Don't worry, we just need to merge it now. Thanks for your contribution!

@cameel cameel changed the title Correct the regex calls Pass count into re.sub() as a named argument in isolate_tests.py to fix the deprecation warning Jun 17, 2025
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@nikola-matic nikola-matic enabled auto-merge June 18, 2025 08:45
@nikola-matic nikola-matic merged commit 584cdcc into ethereum:develop Jun 18, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants