test: add coverage for app.listen() variants #6476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kgarg1
commented
Apr 22, 2025
kgarg1
commented
- verify alternate signatures (port+host+backlog)
- verify server.address() shape
- verify alternate signatures (port+host+backlog) - verify server.address() shape
bjohansebas
approved these changes
Apr 26, 2025
|
thanks @kgarg1! |
wesleytodd
reviewed
Jun 7, 2025
There was a problem hiding this comment.
Not going to ask that these be backed out, but they are testing Node.js apis not Express ones. I know it looks like they are testing listen, but the actual assertions are not.
Typically we don't want to test anything other than our api. I would prefer if we could take a second look at these and try to compare the coverage the add for express code and modify them to better test what that express is correctly passing the values to Node.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.