File tree Expand file tree Collapse file tree 3 files changed +18
-10
lines changed
packages/react-native/ReactCxxPlatform/react/renderer/animated Expand file tree Collapse file tree 3 files changed +18
-10
lines changed Original file line number Diff line number Diff line change @@ -56,7 +56,9 @@ void AnimatedModule::updateAnimatedNodeConfig(
56
56
jsi::Runtime& rt,
57
57
Tag tag,
58
58
jsi::Object config) {
59
- // TODO(T196513045): missing implementation
59
+ // TODO(T196513045): missing implementation. This API is only used by Animated
60
+ // when PlatformColor API is used and animation is updated with a new value
61
+ // through AnimatedColor.setValue.
60
62
}
61
63
62
64
void AnimatedModule::getValue (
@@ -191,11 +193,15 @@ void AnimatedModule::removeAnimatedEventFromView(
191
193
void AnimatedModule::addListener (
192
194
jsi::Runtime& /* rt*/ ,
193
195
const std::string& /* eventName*/ ) {
194
- // TODO(T225953415): missing implementation
196
+ // Not needed in C++ Animated. addListener is used to synchronise event
197
+ // animations like onScroll with React and Fabric. However C++ Animated
198
+ // synchronises with Fabric directly.
195
199
}
196
200
197
201
void AnimatedModule::removeListeners (jsi::Runtime& /* rt*/ , int /* count*/ ) {
198
- // TODO(T225953457): missing implementation
202
+ // Not needed in C++ Animated. removeListeners is used to synchronise event
203
+ // animations like onScroll with React and Fabric. However C++ Animated
204
+ // synchronises with Fabric directly.
199
205
}
200
206
201
207
void AnimatedModule::queueAndExecuteBatchedOperations (
Original file line number Diff line number Diff line change @@ -87,7 +87,7 @@ std::optional<double> NativeAnimatedNodesManager::getValue(Tag tag) noexcept {
87
87
}
88
88
}
89
89
90
- // graph
90
+ # pragma mark - Graph
91
91
92
92
std::unique_ptr<AnimatedNode> NativeAnimatedNodesManager::animatedNode (
93
93
Tag tag,
@@ -235,7 +235,7 @@ void NativeAnimatedNodesManager::dropAnimatedNode(Tag tag) noexcept {
235
235
animatedNodes_.erase (tag);
236
236
}
237
237
238
- // mutations
238
+ # pragma mark - Mutations
239
239
240
240
void NativeAnimatedNodesManager::setAnimatedNodeValue (Tag tag, double value) {
241
241
if (auto node = getAnimatedNode<ValueAnimatedNode>(tag)) {
@@ -280,7 +280,7 @@ void NativeAnimatedNodesManager::stopAnimationsForNode(Tag nodeTag) {
280
280
}
281
281
}
282
282
283
- // drivers
283
+ # pragma mark - Drivers
284
284
285
285
void NativeAnimatedNodesManager::startAnimatingNode (
286
286
int animationId,
@@ -701,7 +701,8 @@ bool NativeAnimatedNodesManager::isOnRenderThread() const noexcept {
701
701
return isOnRenderThread_;
702
702
}
703
703
704
- // listeners
704
+ #pragma mark - Listeners
705
+
705
706
void NativeAnimatedNodesManager::startListeningToAnimatedNodeValue (
706
707
Tag tag,
707
708
ValueListenerCallback&& callback) noexcept {
Original file line number Diff line number Diff line change @@ -78,7 +78,7 @@ class NativeAnimatedNodesManager {
78
78
79
79
std::optional<double > getValue (Tag tag) noexcept ;
80
80
81
- // graph
81
+ # pragma mark - Graph
82
82
83
83
void createAnimatedNode (Tag tag, const folly::dynamic& config) noexcept ;
84
84
@@ -102,7 +102,7 @@ class NativeAnimatedNodesManager {
102
102
103
103
void setAnimatedNodeOffset (Tag tag, double offset);
104
104
105
- // drivers
105
+ # pragma mark - Drivers
106
106
107
107
void startAnimatingNode (
108
108
int animationId,
@@ -127,7 +127,8 @@ class NativeAnimatedNodesManager {
127
127
std::shared_ptr<EventEmitterListener> getEventEmitterListener () noexcept {
128
128
return ensureEventEmitterListener ();
129
129
}
130
- // listeners
130
+
131
+ #pragma mark - Listeners
131
132
132
133
void startListeningToAnimatedNodeValue (
133
134
Tag tag,
You can’t perform that action at this time.
0 commit comments