Skip to content

Fix accessibilityRespondsToUserInteraction not setting on first render #51986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix accessibilityRespondsToUserInteraction not setting on first render #51986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ AccessibilityProps::AccessibilityProps(
rawProps,
"accessibilityRespondsToUserInteraction",
sourceProps.accessibilityRespondsToUserInteraction,
{})),
true)),
onAccessibilityTap(
ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
? sourceProps.onAccessibilityTap
Expand Down
5 changes: 4 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ class AccessibilityProps {
bool accessibilityViewIsModal{false};
bool accessibilityElementsHidden{false};
bool accessibilityIgnoresInvertColors{false};
bool accessibilityRespondsToUserInteraction{};
// This prop is enabled by default on iOS, we need to match this on
// C++ because if not, it will default to false before render which prevents
// the view from being updated with the correct value.
bool accessibilityRespondsToUserInteraction{true};
bool onAccessibilityTap{};
bool onAccessibilityMagicTap{};
bool onAccessibilityEscape{};
Expand Down
Loading