Use HermesExecutorFactory from the internal copy for Meta apps #52001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Internally we have a private cop of the HermesExecutorFactory that we use to run Hermes related experiments before moving the changes to OSS. The RCTCxxBridge class was wrongly setup and was always falling back to JSC instead of Hermes, when an [`executorClass` was not passed](https://github.com/facebook/react-native/blob/main/packages/react-native/React/CxxBridge/RCTCxxBridge.mm#L467). This change should fix it, properly using the right hermes executor class ## Changelog: [Internal] - Differential Revision: D76594037
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76594037 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 13, 2025
…ook#52001) Summary: Pull Request resolved: facebook#52001 Internally we have a private cop of the HermesExecutorFactory that we use to run Hermes related experiments before moving the changes to OSS. The RCTCxxBridge class was wrongly setup and was always falling back to JSC instead of Hermes, when an [`executorClass` was not passed](https://github.com/facebook/react-native/blob/main/packages/react-native/React/CxxBridge/RCTCxxBridge.mm#L467). This change should fix it, properly using the right hermes executor class ## Changelog: [Internal] - Differential Revision: D76594037
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 13, 2025
…ook#52001) Summary: Pull Request resolved: facebook#52001 Internally we have a private cop of the HermesExecutorFactory that we use to run Hermes related experiments before moving the changes to OSS. The RCTCxxBridge class was wrongly setup and was always falling back to JSC instead of Hermes, when an [`executorClass` was not passed](https://github.com/facebook/react-native/blob/main/packages/react-native/React/CxxBridge/RCTCxxBridge.mm#L467). This change should fix it, properly using the right hermes executor class ## Changelog: [Internal] - Differential Revision: D76594037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Internally we have a private cop of the HermesExecutorFactory that we use to run Hermes related experiments before moving the changes to OSS.
The RCTCxxBridge class was wrongly setup and was always falling back to JSC instead of Hermes, when an
executorClasswas not passed.This change should fix it, properly using the right hermes executor class
Changelog:
[Internal] -
Differential Revision: D76594037