Clean up incorrect @VisibleForTesting annotation usages
#52025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@sbuggay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
reviewed
Jun 18, 2025
| @@ -35,7 +34,6 @@ | |||
| * BridgeReactContext. | |||
| */ | |||
| @DeprecatedInNewArchitecture | |||
| @VisibleForTesting | |||
There was a problem hiding this comment.
Let's undo this.
Instead let's
- Make this class Nullsafe
- Convert this class to Kotlin
- Make it internal
To be done in separate PRs if possbile
There was a problem hiding this comment.
Sure thing, this is done now in dd788c5. If you could do a pass for the nullsafe on this one would be great
|
@sbuggay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mateoguzmana in 1d94562 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Static code analysis reports 18 warnings for incorrect usages of the
@VisibleForTestingannotation as some of the classes/functions/properties that are annotated are not used only in tests but also in other non-test files across the codebase. This PR cleans that up to fix those warnings.Changelog:
[INTERNAL] - Clean up incorrect @VisibleForTesting annotation usages
Test Plan: