Skip to content

Clean up incorrect @VisibleForTesting annotation usages #52025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Clean up incorrect @VisibleForTesting annotation usages #52025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1db43
Clean up incorrect @VisibleForTesting usages
mateoguzmana Jun 14, 2025
dd788c5
Revert BridgeReactContext.java changes
mateoguzmana Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
import com.facebook.react.common.LifecycleState;
import com.facebook.react.common.ReactConstants;
import com.facebook.react.common.SurfaceDelegateFactory;
import com.facebook.react.common.annotations.VisibleForTesting;
import com.facebook.react.common.annotations.internal.LegacyArchitecture;
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogLevel;
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger;
Expand Down Expand Up @@ -1115,7 +1114,6 @@ public void removeReactInstanceEventListener(
/**
* @return current ReactApplicationContext
*/
@VisibleForTesting
public @Nullable ReactContext getCurrentReactContext() {
synchronized (mReactContextLock) {
return mCurrentReactContext;
Expand Down
5 changes: 2 additions & 3 deletions ...ges/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstance.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ package com.facebook.react.bridge

import com.facebook.proguard.annotations.DoNotStrip
import com.facebook.react.bridge.queue.ReactQueueConfiguration
import com.facebook.react.common.annotations.VisibleForTesting
import com.facebook.react.common.annotations.internal.LegacyArchitecture
import com.facebook.react.internal.turbomodule.core.interfaces.TurboModuleRegistry
import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder
Expand Down Expand Up @@ -53,7 +52,7 @@ public interface CatalystInstance : MemoryPressureListener, JSInstance, JSBundle
public val isDestroyed: Boolean

/** Initialize all the native modules */
@VisibleForTesting public fun initialize()
public fun initialize()

public val reactQueueConfiguration: ReactQueueConfiguration

Expand Down Expand Up @@ -90,7 +89,7 @@ public interface CatalystInstance : MemoryPressureListener, JSInstance, JSBundle
/** This method registers the file path of an additional JS segment by its ID. */
public fun registerSegment(segmentId: Int, path: String)

@VisibleForTesting public fun setGlobalVariable(propName: String, jsonValue: String)
public fun setGlobalVariable(propName: String, jsonValue: String)

/**
* Do not use this anymore. Use [runtimeExecutor] instead. Get the C pointer (as a long) to the
Expand Down
1 change: 0 additions & 1 deletion ...es/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactSurfaceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ internal constructor(
internal val eventDispatcher: EventDispatcher?
get() = reactHost?.eventDispatcher

@get:VisibleForTesting
internal val isAttached: Boolean
get() = reactHost != null

Expand Down
2 changes: 0 additions & 2 deletions ...actAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import androidx.core.util.Preconditions;
import com.facebook.infer.annotation.Nullsafe;
import com.facebook.react.common.annotations.UnstableReactNativeAPI;
import com.facebook.react.common.annotations.VisibleForTesting;
import com.facebook.react.modules.i18nmanager.I18nUtil;
import com.facebook.react.uimanager.FloatUtil;
import com.facebook.react.uimanager.LengthPercentage;
Expand Down Expand Up @@ -346,7 +345,6 @@ public void setBackgroundImage(@Nullable List<BackgroundImageLayer> backgroundIm
invalidateSelf();
}

@VisibleForTesting
public int getColor() {
return mColor;
}
Expand Down
Loading