Fix crash on ReactInstance due to null returned for getViewManagerNames #52035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76723826 |
This was referenced Jun 16, 2025
|
This pull request was exported from Phabricator. Differential Revision: D76723826 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 16, 2025
…es (facebook#52035) Summary: Pull Request resolved: facebook#52035 Fixes facebook#52014 Some OSS library is still returning null for `getViewManagerNames` especially if they're implementing the `ViewManagerOnDemandReactPackage` in Java. I'm adding a try-catch here so that we prevent the NPE for those scenarios. Changelog: [Android] [Fixed] - Fix crash on ReactInstance due to null returned for getViewManagerNames Reviewed By: javache Differential Revision: D76723826
cortinico
force-pushed
the
export-D76723826
branch
from
ee84e2f to
70f1eda
Compare
…es (facebook#52035) Summary: Pull Request resolved: facebook#52035 Fixes facebook#52014 Some OSS library is still returning null for `getViewManagerNames` especially if they're implementing the `ViewManagerOnDemandReactPackage` in Java. I'm adding a try-catch here so that we prevent the NPE for those scenarios. Changelog: [Android] [Fixed] - Fix crash on ReactInstance due to null returned for getViewManagerNames Reviewed By: javache Differential Revision: D76723826
|
This pull request was exported from Phabricator. Differential Revision: D76723826 |
cortinico
force-pushed
the
export-D76723826
branch
from
70f1eda to
aa87070
Compare
|
This pull request has been merged in f6b7bd9. |
|
This pull request was successfully merged by @cortinico in f6b7bd9 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
…es (#52035) Summary: Pull Request resolved: #52035 Fixes #52014 Some OSS library is still returning null for `getViewManagerNames` especially if they're implementing the `ViewManagerOnDemandReactPackage` in Java. I'm adding a try-catch here so that we prevent the NPE for those scenarios. Changelog: [Android] [Fixed] - Fix crash on ReactInstance due to null returned for getViewManagerNames Reviewed By: javache Differential Revision: D76723826 fbshipit-source-id: cc159dee389257c6877b03a67840a45ee5bec165
|
This pull request was successfully merged by @cortinico in 4d346e2 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #52014
Some OSS library is still returning null for
getViewManagerNamesespecially if they'reimplementing the
ViewManagerOnDemandReactPackagein Java.I'm adding a try-catch here so that we prevent the NPE for those scenarios.
Changelog:
[Android] [Fixed] - Fix crash on ReactInstance due to null returned for getViewManagerNames
Differential Revision: D76723826