Improve how throws from components are reported to the console #52050
+48
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
vzaidman
force-pushed
the
export-D75080385
branch
from
9c9e5c9 to
57bd888
Compare
vzaidman
force-pushed
the
export-D75080385
branch
from
57bd888 to
6377be1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jun 25, 2025
…ook#52050) Summary: Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
vzaidman
force-pushed
the
export-D75080385
branch
from
6377be1 to
18261b5
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jun 25, 2025
…ook#52050) Summary: Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jun 25, 2025
…ook#52050) Summary: Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
vzaidman
force-pushed
the
export-D75080385
branch
from
18261b5 to
dadd1bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
vzaidman
force-pushed
the
export-D75080385
branch
from
dadd1bc to
a5d2497
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jun 25, 2025
…ook#52050) Summary: Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jun 25, 2025
…ook#52050) Summary: Pull Request resolved: facebook#52050 Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
vzaidman
force-pushed
the
export-D75080385
branch
from
a5d2497 to
c6eeda0
Compare
…ook#52050) Summary: Uncaught errors are currently raising a custom error to `console.error`: * With somewhat unclear messaging. * Only the **component stack** is reported. * The top-most stack leads to the component where the throw occurred and not to the actual error being thrown. * The actual error being thrown is never logged After this change: * We print the actual error thrown * The *Owner stack* is attached (see test plan for examples) ## Changelog: [General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components. ---- This is a breaking change because someone might be monkey-patching console.errors, or just listens to them. Reviewed By: rickhanlonii Differential Revision: D75080385
vzaidman
force-pushed
the
export-D75080385
branch
from
c6eeda0 to
195ec84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75080385 |
|
This pull request has been merged in 5ba0e1f. |
|
This pull request was successfully merged by @vzaidman in 5ba0e1f When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Uncaught errors are currently raising a custom error to
console.error:After this change:
Changelog:
[General][Breaking] Improve messaging and add error stack trace in console errors generated on throws from components.
This is a breaking change because someone might be monkey-patching console.errors, or just listens to them.
Differential Revision: D75080385