Fix Facsimile Hit Testing Bugs #52065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
8bc3a0f to
4e417cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
force-pushed
the
export-D76764051
branch
from
4e417cd to
574322e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
574322e to
fc30c94
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
fc30c94 to
20d8805
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
20d8805 to
8c6355a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
8c6355a to
f69c04d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
force-pushed
the
export-D76764051
branch
from
f69c04d to
9d072ac
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 17, 2025
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
NickGerleman
force-pushed
the
export-D76764051
branch
from
9d072ac to
36ae029
Compare
Summary: Pull Request resolved: facebook#52065 1. We can crash when tapping at the boundary between two spans. Previous ReactTextView had some custom heuristic for overlapping ReactTags, assuming they could be nested, which never happens (We only have a single tag per AttributedString fragment), but spans may overlap at a single character, where one is meant to be exclusive, and the other inclusive. We add logic for that. 2. We don't incorporate the offset of the text layout within the view for hit testing, needed for padding or `textAlignVertical`. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D76764051
|
This pull request was exported from Phabricator. Differential Revision: D76764051 |
NickGerleman
force-pushed
the
export-D76764051
branch
from
36ae029 to
f798971
Compare
|
This pull request has been merged in 64ce769. |
|
This pull request was successfully merged by @NickGerleman in 64ce769 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
textAlignVertical.Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D76764051