Skip to content

Gate logic to remove js sync at end of native animation loop #52068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zeyap
Copy link
Contributor

@zeyap zeyap commented Jun 16, 2025

Summary:

Changelog:

[Internal] [Changed] - Gate logic to remove js sync at end of native animation loop

because #51264 is causing regression in some cases, and was recently reverted again in #51933 . Using an extra feature flag to gate this potential optimization

Differential Revision: D76759441

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76759441

Differential Revision: D76763197
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76759441

@zeyap zeyap force-pushed the export-D76759441 branch from 1b16d70 to 4b260bb Compare June 17, 2025 12:58
zeyap added a commit to zeyap/react-native that referenced this pull request Jun 17, 2025
…k#52068)

Summary:
Pull Request resolved: facebook#52068

## Changelog:

[Internal] [Changed] - Gate logic to remove js sync at end of native animation loop

because facebook#51264 is causing regression in some cases, and was recently reverted again in facebook#51933 . Using an extra feature flag to gate this potential optimization

Reviewed By: lenaic

Differential Revision: D76759441
…k#52068)

Summary:
Pull Request resolved: facebook#52068

## Changelog:

[Internal] [Changed] - Gate logic to remove js sync at end of native animation loop

because facebook#51264 is causing regression in some cases, and was recently reverted again in facebook#51933 . Using an extra feature flag to gate this potential optimization

Reviewed By: lenaic

Differential Revision: D76759441
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76759441

@zeyap zeyap force-pushed the export-D76759441 branch from 4b260bb to 9b333d7 Compare June 17, 2025 13:30
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ce75271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants