Skip to content

[ci]: minor optimization in react-devtools artifacts download step #33022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arthur-mountain
Copy link
Contributor

@arthur-mountain arthur-mountain commented Apr 25, 2025

Summary

This change introduces a minor optimization by fetching the original commit only when necessary.

It may prove especially useful for workflows triggered by workflow_dispatch, as it can help improve efficiency, particularly in large-scale projects like React.

How did you test this change?

N/A

@arthur-mountain arthur-mountain changed the title [ci]: … [ci]: minor optimization for conditionally fetching commit SHA when downloading react-devtools artifacts Apr 25, 2025
@arthur-mountain arthur-mountain changed the title [ci]: minor optimization for conditionally fetching commit SHA when downloading react-devtools artifacts [ci]: minor optimization in react-devtools artifacts download step Apr 25, 2025
@react-sizebot
Copy link

react-sizebot commented Apr 25, 2025

Comparing: 143d3e1...ec2edd7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 527.72 kB 527.72 kB = 93.07 kB 93.07 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 633.34 kB 633.34 kB = 111.25 kB 111.25 kB
facebook-www/ReactDOM-prod.classic.js = 671.13 kB 671.13 kB = 117.70 kB 117.70 kB
facebook-www/ReactDOM-prod.modern.js = 661.41 kB 661.41 kB = 116.14 kB 116.14 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 537.01 kB 535.52 kB = 96.21 kB 95.97 kB
oss-experimental/react-markup/cjs/react-markup.development.js = 362.08 kB 360.60 kB = 64.98 kB 64.73 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 320.33 kB 318.83 kB = 59.73 kB 59.54 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 219.88 kB 218.38 kB = 40.48 kB 40.29 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 369.48 kB 366.95 kB = 66.42 kB 65.95 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 392.11 kB 389.33 kB = 69.51 kB 69.04 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 392.11 kB 389.33 kB = 69.51 kB 69.04 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 418.51 kB 415.50 kB = 72.75 kB 72.18 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 417.50 kB 414.49 kB = 72.54 kB 71.97 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 413.42 kB 410.41 kB = 71.92 kB 71.41 kB
facebook-www/ReactDOMServer-dev.classic.js = 381.64 kB 378.87 kB = 68.29 kB 67.81 kB
facebook-www/ReactDOMServer-dev.modern.js = 378.19 kB 375.41 kB = 67.76 kB 67.28 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 350.01 kB 347.41 kB = 66.45 kB 65.97 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 365.44 kB 362.37 kB = 66.27 kB 65.76 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 365.43 kB 362.37 kB = 66.27 kB 65.76 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 365.41 kB 362.34 kB = 66.24 kB 65.74 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 365.41 kB 362.34 kB = 66.24 kB 65.74 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 378.07 kB 374.81 kB = 67.93 kB 67.40 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 377.99 kB 374.73 kB = 67.87 kB 67.35 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 325.33 kB 322.50 kB = 63.20 kB 62.68 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 325.25 kB 322.43 kB = 63.17 kB 62.65 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 382.39 kB 379.03 kB = 68.71 kB 68.17 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 382.32 kB 378.96 kB = 68.66 kB 68.12 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 381.61 kB 378.25 kB = 68.57 kB 68.02 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 381.54 kB 378.18 kB = 68.52 kB 67.97 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 266.42 kB 263.89 kB = 47.21 kB 46.73 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 260.47 kB 257.94 kB = 45.07 kB 44.60 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 262.34 kB 259.74 kB = 46.20 kB 45.75 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js = 238.57 kB 235.99 kB = 42.82 kB 42.42 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 238.03 kB 235.45 kB = 43.42 kB 43.02 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js = 232.95 kB 230.37 kB = 41.51 kB 41.11 kB
facebook-www/ReactDOMServer-prod.classic.js = 224.87 kB 222.29 kB = 40.28 kB 39.88 kB
facebook-www/ReactDOMServer-prod.modern.js = 222.18 kB 219.61 kB = 39.96 kB 39.54 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js = 238.24 kB 235.47 kB = 43.65 kB 43.15 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js = 238.16 kB 235.39 kB = 43.62 kB 43.12 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 226.44 kB 223.80 kB = 41.53 kB 41.11 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js = 234.80 kB 232.01 kB = 42.66 kB 42.17 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js = 234.72 kB 231.93 kB = 42.63 kB 42.15 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js = 233.03 kB 230.26 kB = 41.71 kB 41.19 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js = 232.96 kB 230.19 kB = 41.69 kB 41.17 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.js = 218.49 kB 215.69 kB = 40.65 kB 40.21 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.js = 218.47 kB 215.67 kB = 40.63 kB 40.19 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.js = 213.98 kB 211.18 kB = 38.89 kB 38.46 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.js = 213.95 kB 211.15 kB = 38.87 kB 38.43 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js = 218.27 kB 215.41 kB = 40.08 kB 39.64 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js = 218.19 kB 215.34 kB = 40.05 kB 39.61 kB

Generated by 🚫 dangerJS against ec2edd7

… — especially important for large-scale projects like React.
@arthur-mountain arthur-mountain force-pushed the ci/simplify-optimize-download-react-devtools-artifacts-step-when-dispatch branch from a2080d4 to ec2edd7 Compare April 25, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants