[devtools] Restore "double-click to view owners tree" functionality #33039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Apr 28, 2025
packages/react-devtools-shared/src/devtools/views/Components/TreeContext.js
Outdated
Show resolved
Hide resolved
eps1lon
force-pushed
the
sebbie/rdt-owners-list-fix
branch
from
e989e7f to
84220ef
Compare
eps1lon
commented
Apr 28, 2025
|
|
||
| return ( | ||
| <TreeStateContext.Provider value={state}> | ||
| <TreeDispatcherContext.Provider value={dispatchWrapper}> | ||
| <TreeDispatcherContext.Provider value={dispatch}> |
There was a problem hiding this comment.
Once the double click is no longer in a Transition, we do actually commit the Owners list.
eps1lon
force-pushed
the
sebbie/rdt-owners-list-fix
branch
from
84220ef to
e34c3df
Compare
eps1lon
force-pushed
the
sebbie/rdt-owners-list-fix
branch
from
e34c3df to
8f8a0d8
Compare
hoxyq
approved these changes
Apr 29, 2025
This was referenced May 5, 2025
hoxyq
pushed a commit
to hoxyq/react
that referenced
this pull request
May 7, 2025
hoxyq
added a commit
that referenced
this pull request
May 8, 2025
Patch release to mitigate #32659 Essentially just 6.1.1 with: * Restore all Transitions for Tree updates ([eps1lon](https://github.com/eps1lon) in [#33042](#33042)) * Restore "double-click to view owners tree" functionality ([eps1lon](https://github.com/eps1lon) in [#33039](#33039))
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
Patch release to mitigate #32659 Essentially just 6.1.1 with: * Restore all Transitions for Tree updates ([eps1lon](https://github.com/eps1lon) in [#33042](#33042)) * Restore "double-click to view owners tree" functionality ([eps1lon](https://github.com/eps1lon) in [#33039](#33039)) DiffTrain build for [557a647](557a647)
This was referenced May 13, 2025
This was referenced May 21, 2025
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Double clicking an element to view the Owner tree is currently broken. We change the Owner in a Transition and suspend while we fetch the new Owners list. However, we only resolve that Promise in an Effect and Effects don't commit anywhere until the Transition is finished.
We'd have to refactor
OwnersListContextControllerto trigger the I/O when we actually change the Owner (e.g. usinguseActionStateor moving the I/O down to the dispatch calls.For now we just pass down the basic dispatch and let each call opt-in. We'd have to audit each future call we add until we refactor.
How did you test this change?