Bug Fix: Fixed potential Divide by Zero in zstdcli_trace.c #4379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebres
reviewed
Jun 5, 2025
| double const speed = ((double)trace->uncompressedSize * 1000) / (double)duration; | ||
| const double speed = duration != 0 | ||
| ? ((double)trace->uncompressedSize * 1000) / (double)duration | ||
| : 0.0; |
There was a problem hiding this comment.
Zero speed? Shall not it be INFINITY either?..
However, since duration is a precise time counter (and it's nanosecond precise), I don't think the duration as diff between 2 measurements could be ever 0, because would mean few CPU instructions.
But to be sure (and safe in the future), I'd suggest simply something under its min-value (e. g. small fraction like .1 or 1e-4):
- double const speed = ((double)trace->uncompressedSize * 1000) / (double)duration;
+ double const speed = ((double)trace->uncompressedSize * 1000) / (duration ? (double)duration : .1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix for Issue #4368
In the TRACE_log function in zstdcli_trace.c, in case duration is 0, speed is set to 0, circumventing the potential divide by 0 error.