Trivial: Cast dockerCmd string replace to string. #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: with one of my gitlab pipelines, our usage of service directives over parallel executors was causing node errors to be raised when trying to replace dockerCmd strings that for some reason were not strings. Solution: Force casting the values to be string representations in all cases fixed the issue I was having and is a safer call to make.
firecow
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: with one of my gitlab pipelines, our usage of service directives over parallel executors was causing nodejs errors to be raised when trying to replace dockerCmd strings that for some reason were not strings.
Solution: Force casting the values to be string representations in all cases fixed the issue I was having and is a safer call to make.