Change JX Browser file management to plugin logger #8320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to change over classes that are logging to using the plugin logger. In this case there were some file paths being logged and I removed those; however, now I'm thinking about whether it would make sense to allow logs with file paths to help users debug on their own (perhaps as a setting that's off by default?). Anyway, that's more a topic for a doc. In this case, I think our JX Browser download process is fairly stable and does not require file details.