Skip to content

Change JX Browser file management to plugin logger #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jul 8, 2025

I was planning to change over classes that are logging to using the plugin logger. In this case there were some file paths being logged and I removed those; however, now I'm thinking about whether it would make sense to allow logs with file paths to help users debug on their own (perhaps as a setting that's off by default?). Anyway, that's more a topic for a doc. In this case, I think our JX Browser download process is fairly stable and does not require file details.

@helin24 helin24 requested a review from jwren July 8, 2025 15:38
@helin24 helin24 merged commit 63b56cf into flutter:master Jul 8, 2025
8 checks passed
@helin24 helin24 deleted the jxbrowser-log branch July 8, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants