Bump blockifier to 0.14.0 #3416

franciszekjob · 2025-05-28T09:57:36Z

Towards #3174

Stack:

Introduced changes

Bump blockifier to v0.14.0

Checklist

…s/starknet-foundry into 3174-blockifier-0.14.0

crates/cheatnet/src/runtime_extensions/common.rs

… into 3174-blockifier-0.14.0

crates/sncast/Cargo.toml

This reverts commit 96e49ed.

…go.toml`

cptartur

Looks good

cptartur · 2025-06-11T15:08:07Z

crates/cheatnet/src/forking/state.rs

-        if err_str.contains("error sending request for url") {
+        if err_str.contains("error sending request") {


We mostly throw these errors from ForkStateReader, I think it's unlikely it's coming from blockifier itself, it's not making any requests to the network.
It might be from reqwest or some other network related package maybe?

cptartur · 2025-06-11T15:11:20Z

Cargo.toml

@@ -29,22 +29,22 @@ license = "MIT"
 license-file = "LICENSE"

 [workspace.dependencies]
-blockifier = { git = "https://github.com/software-mansion-labs/sequencer.git", branch = "main-v0.13.5-modified-sierra-dep", default-features = false, features = ["testing", "tracing"] }
+blockifier = { git = "https://github.com/starkware-libs/sequencer.git", branch = "main-v0.14.0", default-features = false, features = ["testing", "tracing"] }


Supposedly there has been an RC crates release for blockifier but it's quite old at this point. We should probably still track a branch and monitor releases.

Yup, it's quite old.

Let's upgrade it once there's something not rc released.

cptartur · 2025-06-11T15:11:50Z

crates/cheatnet/src/runtime_extensions/common.rs

+            let syscall_gas_cost = syscall_gas_costs
+                .get_syscall_gas_cost(selector)
+                .expect("Failed to get syscall gas cost");


Let's both improve the error and test it with maat eventually.

crates/data-transformer/src/shared/parsing.rs

cptartur · 2025-06-11T15:14:32Z

crates/forge/tests/data/contracts/gas_checker.cairo

+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);


Did you link the correct comment? How are deprecated syscalls related to this?

crates/sncast/Cargo.toml

ddoktorski · 2025-06-12T11:14:58Z

crates/forge-runner/src/build_trace_data.rs

 ) -> ProfilerDeprecatedSyscallSelector {
    match value {
        DeprecatedSyscallSelector::CallContract => ProfilerDeprecatedSyscallSelector::CallContract,
        DeprecatedSyscallSelector::DelegateCall => ProfilerDeprecatedSyscallSelector::DelegateCall,
        DeprecatedSyscallSelector::DelegateL1Handler => {
            ProfilerDeprecatedSyscallSelector::DelegateL1Handler
        }
-        DeprecatedSyscallSelector::Deploy => ProfilerDeprecatedSyscallSelector::Deploy,
+        DeprecatedSyscallSelector::Deploy | DeprecatedSyscallSelector::MetaTxV0 => {


Maybe let's add a separate arm for MetaTxV0 with a TODO comment?

Actually, I've added it as a variant of ProfilerDeprecatedSyscallSelector in cairo-aoontations, so should be fine now.

crates/forge/tests/integration/gas.rs

cptartur

Didn't

cptartur · 2025-06-13T16:00:04Z

Cargo.toml

@@ -29,22 +29,22 @@ license = "MIT"
 license-file = "LICENSE"

 [workspace.dependencies]
-blockifier = { git = "https://github.com/software-mansion-labs/sequencer.git", branch = "main-v0.13.5-modified-sierra-dep", default-features = false, features = ["testing", "tracing"] }
+blockifier = { git = "https://github.com/starkware-libs/sequencer.git", branch = "main-v0.14.0", default-features = false, features = ["testing", "tracing"] }


Let's upgrade it once there's something not rc released.

cptartur · 2025-06-13T16:02:04Z

crates/forge/tests/data/contracts/gas_checker.cairo

+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);
+            core::pedersen::pedersen(1, 2);


Right, make sense. Steps are more expensive without these much repetitions of pedersen?

ksew1 · 2025-06-16T07:25:59Z

crates/forge-runner/src/build_trace_data.rs

    gas_consumed: u64,
 ) -> ProfilerExecutionResources {
-    let mut profiler_syscall_counter = HashMap::new();


Please don't delete this it will be used in #3472

franciszekjob and others added 19 commits May 28, 2025 11:01

Bump deps

bb76c40

Bump cairo-vm; Fix compilation errors

f551a59

Update mocked storage access tracker in mocked_call_info

e4afe6f

Remove build_profiler_deprecated_syscall_selector

d6ee1da

Update asserted gas values in integration gas tests

676ed86

Fix test_calling_nonexistent_url

f69a22f

Temporarily add print in assert_gas

33a4d32

More prints

ab2695b

More prints

f15529d

More prints

4a1c9c6

Update asserted values in gas integration tests

f16f541

Update asserted gas in events_contract_cost_sierra_gas

e71196b

Merge branch 'master' into 3174-blockifier-0.14.0

a24f2c8

Remove todo

8ef2ca5

Remove some todos

4d7268e

Merge branch '3174-blockifier-0.14.0' of https://github.com/foundry-r…

78357f8

…s/starknet-foundry into 3174-blockifier-0.14.0

Update todos

284b6f6

Resolve some todos

a75c809

Update todo

14bdc63

ddoktorski reviewed Jun 2, 2025

View reviewed changes

crates/cheatnet/src/runtime_extensions/common.rs Outdated Show resolved Hide resolved

franciszekjob added 8 commits June 2, 2025 13:33

Bump cairo-vm to 2.2.0

bed8d94

Merge branch 'master' of https://github.com/foundry-rs/starknet-foundry…

117dda7

… into 3174-blockifier-0.14.0

Remove unnecessary change for base_cost calculation

1690f70

Resolve todos for missing path segments

586643f

Fix formatting

8af190c

Change usage of DeprecatedSyscallSelector to SyscallSelector

050f29a

Fix gas values in failing tests

721f241

Change branch name used for cairo-annotations

dd5fbf1

franciszekjob mentioned this pull request Jun 4, 2025

Use CallEntryPoint.into_executable() #3417

Open

5 tasks

Restore error string in other_provider_error

44e8e13

Update 2.12.0-dev.1 to 2.12.0-rc.0

96e49ed

kkawula reviewed Jun 9, 2025

View reviewed changes

crates/sncast/Cargo.toml Show resolved Hide resolved

franciszekjob added 10 commits June 9, 2025 15:16

Revert "Update 2.12.0-dev.1 to 2.12.0-rc.0"

52fd891

This reverts commit 96e49ed.

Move cairo-lang-runner and cairo-lang-runnable-utils to main `Car…

a804b0a

…go.toml`

Bump Cairo deps to 2.12-rc.0

20cf73b

Restore build_profiler_deprecated_syscall_selector

b75a266

Fix compilation errors

6d55611

Remove todo

32a0b4f

Fix linting

941aa25

Use parse_argument_list for WrappedTokenTree::Bracketed variant

762af6e

Update parsing bracketed case in parse_inline_macro

c2b15ef

Fix linting

343b7d2

franciszekjob requested review from kkawula and ksew1 June 10, 2025 16:40

Apply code review suggestion

eac1fab

cptartur reviewed Jun 11, 2025

View reviewed changes

ddoktorski requested changes Jun 12, 2025

View reviewed changes

franciszekjob added 7 commits June 12, 2025 14:35

Apply code review suggestions

0cb0ecb

Fix gas value

b4787c9

Update gas values

3798c27

Fix compilation error

8398309

Fix compilation error

761be9d

Update cairo-annotations

80016a2

Fix linting

87038e1

franciszekjob requested review from cptartur and ddoktorski June 12, 2025 14:02

Fix linting

53f5124

cptartur approved these changes Jun 13, 2025

View reviewed changes

ksew1 reviewed Jun 16, 2025

View reviewed changes

ddoktorski mentioned this pull request Jun 16, 2025

Release 0.45.0 #3475

Merged

		if err_str.contains("error sending request for url") {
		if err_str.contains("error sending request") {

Bump blockifier to 0.14.0 #3416

Are you sure you want to change the base?

Bump blockifier to 0.14.0 #3416

Uh oh!

Conversation

franciszekjob commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduced changes

Checklist

Uh oh!

Uh oh!

Uh oh!

cptartur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cptartur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ksew1 Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

franciszekjob commented May 28, 2025 •

edited

Loading

ksew1 Jun 16, 2025 •

edited

Loading