-
Notifications
You must be signed in to change notification settings - Fork 229
Replacing snforge_new
with snforge_std_compatibility
in tests
#3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cptartur
wants to merge
10
commits into
spr/master/dc2f7a0d
Choose a base branch
from
spr/master/2d2e4851
base: spr/master/dc2f7a0d
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit-id:5f7f388c
commit-id:d71f675d
commit-id:3ae67c8b
commit-id:5e47ad12
commit-id:34dd50be
commit-id:4ff317d1
commit-id:96b0213f
Closes #3461 commit-id:182fb50c
commit-id:dc2f7a0d
commit-id:2d2e4851
This was referenced Jun 13, 2025
Open
Open
Not sure about this solution. It replaces Alternative solution is to have scripts that replace file contents in CI and we run as always. |
Important, this PR causes most (or all) tests to use old plugin (v1 syntax) so it should not be treated as a test reference of macros. See PRs before this one. |
0af99ff
to
1968a6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
snforge_new
withsnforge_std_compatibility
in tests #3471 ⬅_std
packages #3470snforge_std
orsnforge_std_compatibility
insnforge
new #3466_compatibility
plugin #3465_compatibility
package #3464scarbfmt
#3419