Skip to content

Run tests on a new and compatibility plugin #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: spr/master/dc2f7a0d
Choose a base branch
from
Open

Run tests on a new and compatibility plugin #3502

wants to merge 1 commit into from
+804 −295

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Jun 27, 2025 •
edited
Loading

This was referenced Jun 27, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from 39770df to 8bad799 Compare June 27, 2025 14:38
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 4 times, most recently from 792d9d7 to d181402 Compare June 27, 2025 14:57
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from 8bad799 to d776708 Compare June 27, 2025 14:57
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from d181402 to 9d73856 Compare July 1, 2025 13:14
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from d776708 to ce7d760 Compare July 1, 2025 13:14
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 2 times, most recently from 0196e33 to db92b64 Compare July 1, 2025 13:25
@cptartur cptartur marked this pull request as ready for review July 1, 2025 13:58
@cptartur cptartur requested a review from a team as a code owner July 1, 2025 13:58
@cptartur cptartur requested review from ddoktorski and franciszekjob and removed request for a team July 1, 2025 13:58
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from db92b64 to d7e674b Compare July 2, 2025 09:39
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from 0af99ff to 1968a6b Compare July 2, 2025 09:39
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 3 times, most recently from 3186dc4 to 33f45dd Compare July 2, 2025 11:14
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 3 times, most recently from 2b93435 to bcb3b83 Compare July 3, 2025 09:20
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from f612cfa to e80a639 Compare July 3, 2025 12:19
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 2 times, most recently from 00670f3 to 6b9ad82 Compare July 3, 2025 21:07
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from e80a639 to 0dfb245 Compare July 3, 2025 21:07
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from 6b9ad82 to ad5c0db Compare July 9, 2025 13:42
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from 0dfb245 to dd729c7 Compare July 9, 2025 13:42
ddoktorski
ddoktorski reviewed Jul 9, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
- uses: software-mansion/setup-scarb@v1
with:
scarb-version: 2.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be annoying during local development, it will format with Scarb 2.12, but CI will check formatting with version 2.10.1. It would be better to simply omit std compatibility in this check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change that

.tool-versions
@@ -1,2 +1,2 @@
scarb nightly-2025-06-18
scarb nightly-2025-06-18 2.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on purpose, the new tests need both scarb 2.10.1 and 2.12 (pre-release). It turns out you can have multiple versions in .tool-versions and asdf install will install all of them (but use the first).

@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from dd729c7 to 6f0ae3c Compare July 10, 2025 10:39
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch 2 times, most recently from 8f8951e to aa92710 Compare July 10, 2025 13:50
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from 6f0ae3c to f768358 Compare July 10, 2025 13:50
@cptartur cptartur force-pushed the spr/master/aa2a40e5 branch from aa92710 to d2431f5 Compare July 10, 2025 17:12
@cptartur cptartur force-pushed the spr/master/dc2f7a0d branch from f768358 to 72c4761 Compare July 10, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski left review comments

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cptartur @ddoktorski @franciszekjob